Bug 306777

Description Paul Fullbright 2010-03-22 18:32:08 EDT

There are several areas where validation and defaults are not calculated correctly when a relationship uses the maps id setting.

I: Id mapping that is mapped by a relationship (bug 294271) 

@Entity
public class Person {
    @Id
    String ssn;
}

@Entity
public class MedicalHistory {
    @Id
    String id; // overriding not allowed

    // default join column name ("patient_ssn") is overridden
    @MapsId("id")
    @JoinColumn(name="FK")
    @OneToOne
    Person patient;
}

In this case, the ssn attribute on Person should not have a default column, and it should also not validate its column.  In fact, there should be a validation error if the column *is* specified.


II: Embedded id mapping that is mapped by a relationship

@Embeddable
public class PersonId
{
	String firstName;
	
	String lastName;
}

@Entity(name = "Person_6")
public class Person {
	@EmbeddedId
	PersonId id;
}

@Entity(name = "MedicalHistory_6b")
public class MedicalHistory {
	@EmbeddedId
	PersonId id;
	
	@OneToOne
	@MapsId
	@JoinColumns({
		@JoinColumn(name="FK1", referencedColumnName="FIRSTNAME"),
		@JoinColumn(name="FK2", referencedColumnName="LASTNAME")})
	Person patient;
}

In this case, the id attribute on MedicalHistory should not have any implied attribute overrides (usually all attributes on PersonId would be implied, with appropriate default column and table name).  Any attribute overrides specified on the id attribute should in fact be invalidated.


III: Attribute override that is mapped by a relationship (bug 294266)

There are two ways to illustrate this.

IIIa.  Attribute override on an embedded id mapping

public class EmployeeId {
	String firstName;
	
	String lastName;
}

@Entity(name = "Employee_2")
@IdClass(EmployeeId.class)
public class Employee {
	@Id
	String firstName;
	
	@Id
	String lastName;
}

@Embeddable
public class DependentId {
	String name;
	
	EmployeeId empPk;
}

@Entity(name = "Dependent_2b")
public class Dependent {
	@EmbeddedId
	DependentId id;
	
	@ManyToOne
	@MapsId("empPk")
	@JoinColumns({
		@JoinColumn(name="FK1", referencedColumnName="FIRSTNAME"),
		@JoinColumn(name="FK2", referencedColumnName="LASTNAME")})
	Employee emp;
}

In this case, the attribute overrides "empPk.firstName" and "empPk.lastName" should not be defaulted in for the embedded id "id".  These attribute overrides already have columns associated via the subattribute "empPk" being mapped by the relationship.

IIIb. Attribute overrides on an entity

@MappedSuperclass
public abstract class Person {
	@Id
	int ssn;
}

@Entity
@Table(name = "Employee_7b")
public class Employee
	extends Person {
	
}

@Entity
@Table(name = "Dependent_7b")
public class Dependent extends Person {
	@ManyToOne
	@MapsId("ssn")
	protected Employee emp;
}

In this case, the attribute override "ssn" should not be defaulted in for the entity "Dependent".  This attribute override already has a column associated via the "ssn" attribute being mapped by the relationship.

In addition, for the above two cases, if attribute overrides have been specified, there should be a validation error.