Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 306755

Summary: [BiDi][content assist] Hebrew ComplexExpression-Bidi data in parameter hints is unreadable (BIDI3.6_BDL)
Product: [Eclipse Project] JDT Reporter: Ira Fishbein <fira>
Component: TextAssignee: Dani Megert <daniel_megert>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: camle, daniel_megert, fira, kitlo, Olivier_Thomann, pwebster, sadir, tomerm
Version: 3.6   
Target Milestone: 3.6 M7   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Parameters list is reversed
none
HebrewProject none

Description Ira Fishbein CLA 2010-03-22 15:01:00 EDT 
Build Identifier: 3.6.0 - I20100313-1044

1. Open Eclipse, create Java project and java class inside the project
2. Declare some Hebrew-named method which recieves two Hebrew-named parameters
of Hebrew-named types
3. Create anothe method, start typing the Hebrew name of previously created method and press Ctrl+Space
4. Select required method and use SourceAssist in order to add parameters
Result: Hebrew data in appeared hint appears wrongly. The prder of parameters is reversed (see attached screenshot)

Reproducible: Always
Comment 1 Ira Fishbein CLA 2010-03-22 15:02:00 EDT 
Created attachment 162710 [details]
Parameters list is reversed
Comment 2 Olivier Thomann CLA 2010-03-22 16:41:04 EDT 
Move to JDT/UI
Comment 3 Dani Megert CLA 2010-03-23 03:45:32 EDT 
Ira, would it be possible to attach a little test project?
Comment 4 Ira Fishbein CLA 2010-03-23 04:25:35 EDT 
Created attachment 162746 [details]
HebrewProject
Comment 5 Dani Megert CLA 2010-03-23 04:44:33 EDT 
Just to make sure: you are starting Eclipse with -nl iw, right? Using just -dir rtl won't give you correct results. You can verify the locale via:
1. Help > About Eclipse SDK
2. click 'Installation Details'
3. switch to 'Configuration' tab
4. what are the values for
   osgi.nl
   user.country
   user.language
   ?
Comment 6 Ira Fishbein CLA 2010-03-23 05:04:06 EDT 
(In reply to comment #5)
> Just to make sure: you are starting Eclipse with -nl iw, right? Using just -dir
> rtl won't give you correct results. You can verify the locale via:
I call eclipse with "-nl he -dir ltr"
> 1. Help > About Eclipse SDK
> 2. click 'Installation Details'
> 3. switch to 'Configuration' tab
> 4. what are the values for
>    osgi.nl 
iw
>    user.country
IL
>    user.language
iw
>    ?
Comment 7 Dani Megert CLA 2010-03-23 05:28:26 EDT 
>I call eclipse with "-nl he -dir ltr"
That setup is not supported. Please only use "-nl he" and retest all the bugs you filed by using the correct arguments. Please update all those bugs so we know that they are still valid. Thanks!
Comment 8 Dani Megert CLA 2010-03-23 05:42:43 EDT 
The project looks scrambled to me. What encoding did you use?
Comment 9 Ira Fishbein CLA 2010-03-23 05:48:01 EDT 
Cp1255 (Windows Hebrew)
Comment 10 Tomer Mahlin CLA 2010-03-23 05:50:36 EDT 
Daniel, I have several clarifications to share:

1. Bidi support in JDT (StyledText widget based) editor is not conditioned by
locale. As opposed to that TextProcessor (so far the most popular tool for
resolution of complex expressions problems) is conditioned on locale. 
2. Combination of "-nl he -dir ltr" is supported. As a matter of fact this is
the only combination which allows support for complex expressions in English
(not translated and not mirrored) version of Eclipse.
3. "Dir" option should not affect JDT (StyledText widget based) editor which
always stay as not mirrored. In other words for both "-nl he -dir ltr" and "-nl
he" you should get the "same" JDT editor.
4. Bidi support in JDT (in this context) was added by Lina via bug 106638 and
bug 229226. This is only to help locate the relevant portion of the code.
Comment 11 Dani Megert CLA 2010-03-23 05:57:17 EDT 
Yes, I know all those points and "not supported" was the wrong term I used. What I meant is that we (the dev team) normally test the out of the box scenario in which case it would be e.g. -nl he without re-switching the orientation. And yes, it should not affect the rendering of the string itself.


>Cp1255 (Windows Hebrew)
FYI: You can set the encoding on a project. That way the exported project is portable.
Comment 12 Dani Megert CLA 2010-03-23 13:14:41 EDT 
Fixed in HEAD.
Available in builds >= N20100323-2000.
Comment 13 Ira Fishbein CLA 2010-04-18 09:03:01 EDT 
was verified in b20100414-1200