Bugzilla – Full Text Bug Listing
| Summary: | Better CVS watch/edit options needed for prompts when a read-only file is modified in an editor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Ed Burnette <ed.burnette> | ||||
| Component: | Team | Assignee: | Jean-Michel Lemieux <jean-michel_lemieux> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P4 | Keywords: | helpwanted | ||||
| Version: | 2.1 | ||||||
| Target Milestone: | 3.0 M7 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
We're about done for 2.1 watch/edit, post 2.2 or open for community supplied patch. Created attachment 7565 [details]
Prompt choices are provided when editing read-only files
Fix released to HEAD. Reassigned for verification Thanks. I didn't go over the patch in detail but I happened to notice some missing $NON-NLS-1$ comments for the new preference keys. +++ src/org/eclipse/team/internal/ccvs/ui/CVSUIPlugin.java 26 Jan 2004 16:24:15 -0000 + public static final String NEVERPROMPT = "neverPompt"; + public static final String ALWAYSPROMPT = "alwaysPompt"; + public static final String ONLYPROMPT = "onlyPompt"; +++ src/org/eclipse/team/internal/ccvs/ui/ICVSUIConstants.java 26 Jan 2004 16:24:15 -0000 + public final String PREF_EDIT_PROMPT = "pref_edit_prompt"; Patch was applied correctly and I verified that the strings in the patch have been NLS'd. Prompting works, but again, I never use watch/edit and thus aren't that familiar with the workflows. Verified behavior. Looks good, thanks. |
The CVS Watch/Edit dialog needs some more options to allow always prompting whether or not their are other editors. This would be similar to the Visual Studio behavior some people (like me) are used to. I suggest breaking the current radio buttons into two independent options similar to this: "When read-only files are modified in an editor... x Perform a cvs edit Prompt first: o never o always o only if there are other editors" (x is a check box, and o is a radio button)