Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 306531

Summary:	key bindings of some debug actions might be broken
Product:	[Eclipse Project] JDT	Reporter:	Dani Megert <daniel_megert>
Component:	Debug	Assignee:	JDT-Debug-Inbox <jdt-debug-inbox>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	darin.eclipse, pwebster
Version:	3.6
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	300526
Bug Blocks:

Description Dani Megert

2010-03-19 10:44:11 EDT

3.6 M6.

See bug 300526 for details. The following scan shows the possibly affected actions: https://bugs.eclipse.org/bugs/attachment.cgi?id=161870.

Key binding support for those actions needs to be tested and if broken, a default handler be registered where the command is defined in plugin.xml.

Comment 1 Darin Wright

2010-03-23 16:31:02 EDT

All key bindings still work, however I found the following:

* key binding (Alt-Enter) does not display for the breakpoint properties action ("Properties...) in the contenxt menu in the Breakpoints view, but the key binding works

Comment 2 Darin Wright

2010-03-23 16:33:09 EDT

There is an object contribution action, associated command and key binding. Paul, do you know if there's something special debug needs to do to get the key binding to appear in the menu?

Comment 3 Paul Webster

2010-03-29 10:20:02 EDT

(In reply to comment #2)
> There is an object contribution action, associated command and key binding.

Does the objectContribution/action specify the definitionId?

PW

Comment 4 Darin Wright

2010-04-05 10:16:35 EDT

Yes, I think it all aligns... 

the object contribution:

...
<action
               class="org.eclipse.jdt.internal.debug.ui.actions.JavaBreakpointPropertiesAction"
               definitionId="org.eclipse.jdt.debug.ui.breakpoint.properties"
               enablesFor="1"
               helpContextId="breakpoint_properties_action_context"
               id="org.eclipse.jdt.debug.ui.actions.JavaBreakpointProperties"
               label="%JavaBreakpointProperties.label"
               menubarPath="additions">
         </action>
      </objectContribution>

The command:

<command
            categoryId="org.eclipse.debug.ui.category.run"
            description="%ActionDefinition.breakpointproperties.description"
            id="org.eclipse.jdt.debug.ui.breakpoint.properties"
            name="%CommandDefinition.breakpointproperties.name">
      </command> 

The key:

  <key
         commandId="org.eclipse.jdt.debug.ui.breakpoint.properties"
         contextId="org.eclipse.debug.ui.BreakpointView"
         schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
         sequence="M3+ENTER">
   </key>

Comment 5 Paul Webster

2010-04-05 11:08:25 EDT

(In reply to comment #1)
> * key binding (Alt-Enter) does not display for the breakpoint properties action
> ("Properties...) in the contenxt menu in the Breakpoints view, but the key
> binding works

This is an unrelated interaction between the same keys used in different contexts (well, displaying them in the menu since the key bindings themselves work fine).  I've opened bug 308076 for that.

PW

Comment 6 Darin Wright

2010-04-05 11:20:34 EDT

Thanks Paul. Marking this bug as works for me since no changes were required in debug.