Bugzilla – Full Text Bug Listing
| Summary: | Debug preference pages cut of in High Contrast | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Tod Creasey <Tod_Creasey> | ||||
| Component: | Debug | Assignee: | Darin Swanson <Darin_Swanson> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | darin.eclipse, Darin_Swanson, jared_burns, Kevin_Haaland, n.a.edgar | ||||
| Version: | 2.1 | Keywords: | accessibility | ||||
| Target Milestone: | 3.0 M9 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Tod Creasey
Can we do the same with this as we did for the exceptions dialog? Setup: WinXP at 1024x768 in High Contrast mode Simply applying the scaling approach used for the exception dialog won't work. Some of the pages can be made to fit by removing all vertical spacers, at the expense of making the pages much harder to read in 'normal' mode, but the JavaDebug & LaunchHistory pref pages still don't fit because there is nothing to scale (i.e., no variable height trees, lists or tables). All the widgets in these pages are fixed height, and in high contrast mode with its enormous font, it just doesn't fit. The real problem I see here is that if we are required to make these pref pages viewable in High Contrast mode at 1024x768, then we will have to break up some of the pages into multiple pages and remove vertical spacers from others. This results in pages that are less intuitive, and harder to use and view in 'normal' mode. Can we get a definite answer as to whether this is required and/or a pointer to the relevant specs? Thanks. I just discovered that it is possible to vary the font size in High Contrast mode by clicking the 'Settings' button next to the High Contrast checkbox. The default is High Contrast (large), but if you choose just plain High Contrast, everything fits with plenty of room to spare. Tod, is this an acceptable solution to this problem? No - you need to support High Contrast out of the box which basically is an 18 point font for the dialog font. Nick please advise if the requirements are not so strict as this. However I think you are making this too hard on yourself - I think changing the orientation of the save dirty editors radio buttons is all you need to do on the Debug page. However the Launch History one is going to be a problem because of all of the buttons but you really don't want to break it up (I think its current design in pretty good). Rather than messing up you nice dialog I would put the whole thing in a ScrolledComposite and be sure that the page sizes correctly (i.e. use the computeSize from the unscrolled Composite as your result of computeSize). I really think we should avoid breaking up well designed dialogs to satisfy this. I am trying to get better input on the minimum requirements for high contrast mode from the accessibility center. At this point, if our dialogs fit in High Contrast but not High Contrast (large), I would favour other PRs. Marking as LATER. Will reconsider when we know for sure what the requirements are for HIGH CONTRAST. Still an issue at 1152x764 (the newer requirement) but only for the Debug preference page - the others are fine. The requirements are 1152x764 display Windows XP High Contrast mode I am going to reopen this as it will be an issue for the 3.0 accessibility revue *** Bug 54340 has been marked as a duplicate of this bug. *** As per bug 54340, we plan to address this by creating a new "launching" preference page. Implemented. While I was at it, I also changed the "save on launch" preference to be a standard ALWAYS/NEVER/PROMPT preference like the rest of our preferences. I also reworked all of the message keys to follow the Type.number format and fixed up the mnemonics. Changes to: DebugUIPlugin - Use new "save on launch" preference constant DebugPreferencePage - Removed launching preference widgets DebugPreferencesMessages- Reworked message keys and mnemonics LaunchingPreferencePage - Created page and added launching preference widgets IDebugUIConstants - Removed old always/never/prompt value constants and replaced "save on launch" preference key to avoid backwards compatibility problems with the old values plugin.properties - key/value for new preference page plugin.xml - added new preference page Please verify, DarinS. From my review all of the debug preference pages are fully visible on high contrast. Verfied. View Management is still cut off (the others are fine) I will attach a screenshot Created attachment 10891 [details]
Screenshot
There are no buttons hidden in the attached screenshot. You just can't see the bottom of the group. The group wasn't really important in this case so I just removed it. Please verify, DarinS. Verified. |