Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 306245

Summary: [gerrit] provide Gerrit integration for Mylyn
Product: z_Archived Reporter: Steffen Pingel <steffen.pingel>
Component: MylynAssignee: Steffen Pingel <steffen.pingel>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: b.muskalla, caniszczyk, daniel, ingemar.olsen, kilian.matt, mario.bernhart, michael.kober, mn, sascha.scholz, sop, stefan.lay
Version: unspecifiedKeywords: noteworthy, plan
Target Milestone: 0.7   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Proof-of-concept code for Mylyn/Gerrit integration
none
AbstractGerritService.java none

Description Steffen Pingel CLA 2010-03-17 14:13:41 EDT
Gerrit is a terrific code review tool for Git. At Eclipse, the EGit/JGit projects make exclusive use of Gerrit when it comes to reviewing patches. It would be great if there was Mylyn integration for Gerrit so we don't have to leave the comfort of Eclipse to do the actual reviews.
Comment 1 Steffen Pingel CLA 2010-03-29 01:16:33 EDT
Some notes from a conversation at EclipseCon: Gerrit has a JSON remote API that supports interactions in the web interface and could be leveraged by a Mylyn connector. Alternatively communication could be handled by JGit through ssh which may simplify authentication etc. It would depend on the specific needs of the connector which implementation (or a mix of both) would work best. The JGit/Gerrit project is willing to support changes or enhancements to the remote API in either case.

On the Mylyn end the following things would need to be completed for a working proto-type:

* Review data model
* Support for remote access to Gerrit
* Some configuration UI for Gerrit repositories
* Basic task editor integration to view review details

The first step would be to provide a data model, preferably using a model driven approach extending the data model that the Mylyn Review project will provide. For a GSoC project there would be no need to provide offline support or generic APIs or build on a framework. Extraction of a common review framework would be out of scope and could happen at a later point.

The data model would be populated using the remote API and a basic UI layer would be needed to interact with Gerrit repositories and reviews etc. For a GSoC project the UI layer could be kept very simple since most of that should be provided  in a generic way by the Mylyn Review project and could be integrated at a later point. It is likely that the UI layer will be work in progress while the Gerrit connector is developed.
Comment 2 Tomas Westling CLA 2010-09-14 03:58:57 EDT
Created attachment 178793 [details]
Proof-of-concept code for Mylyn/Gerrit integration

This is the proof-of-concept code that we developed at Sony Ericsson.
This is my confirmation that I:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 3 Michael Kober CLA 2010-09-14 04:39:25 EDT
Proof-of-concept code that we developed at Sony Ericsson.
This is my confirmation that I:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 4 Ingemar Ols�n CLA 2010-09-14 05:11:24 EDT
Proof-of-concept code that we developed at Sony Ericsson.
This is my confirmation that I:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 5 Daniel Olsson CLA 2010-09-14 08:36:03 EDT
Proof-of-concept code that we developed at Sony Ericsson.
This is my confirmation that I:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 6 Shawn Minto CLA 2010-09-24 16:56:07 EDT
Created attachment 179546 [details]
AbstractGerritService.java
Comment 7 Steffen Pingel CLA 2010-10-22 14:30:52 EDT
Thanks everyone! I have imported the initial version of the connector into the Git repository. Please note that some of the dependencies are still under IP review and not yet available on Eclipse.org.