Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 305687

Summary: Bugzilla query dialog opens with wrong sizing
Product: z_Archived Reporter: Tomasz Zarna <tomasz.zarna>
Component: MylynAssignee: Frank Becker <eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: eclipse, robert.elves
Version: dev   
Target Milestone: 3.4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Edit Repo Query dialog
none
commited patch
none
mylyn/context/zip
none
screenshot
none
commited patch
none
mylyn/context/zip
none
commited patch
none
mylyn/context/zip
none
screenshot none

Description Tomasz Zarna CLA 2010-03-12 09:50:37 EST
Created attachment 161883 [details]
Edit Repo Query dialog

I20100311-1616 + Mylyn 3.4.0.I20100308-0400-e3x

I've got an old bugzilla query in my Task list. Today I wanted to update it and this is what I saw (see the screenshot).

Expanding the "more Options" group fixes the problem.
Comment 1 Robert Elves CLA 2010-04-08 15:47:07 EDT
Frank, can the dialog be resized to better fit the collapsed state here?
Comment 2 Frank Becker CLA 2010-04-08 16:04:42 EDT
Created attachment 164282 [details]
commited patch
Comment 3 Frank Becker CLA 2010-04-08 16:04:44 EDT
Created attachment 164283 [details]
mylyn/context/zip
Comment 4 Frank Becker CLA 2010-04-08 16:05:05 EDT
Fix is in HEAD
Comment 5 Steffen Pingel CLA 2010-04-08 18:01:25 EDT
The fix does not work too well for me the dialog still comes up too small (see screenshot).
Comment 6 Steffen Pingel CLA 2010-04-08 18:02:18 EDT
Created attachment 164306 [details]
screenshot
Comment 7 Steffen Pingel CLA 2010-04-08 18:15:37 EDT
I also don't think it's the right fix to make the dialog smaller. The list boxes should scale to the size of the dialog instead but that is tracked on bug 305568. Frank, can you try mirroring the behavior of the search dialog? It only packs the dialog if the saved dialog size is too small to show all widgets.
Comment 8 Frank Becker CLA 2010-04-09 08:18:47 EDT
Created attachment 164360 [details]
commited patch

For the Mac OS this looks fine.
Comment 9 Frank Becker CLA 2010-04-09 08:18:50 EDT
Created attachment 164361 [details]
mylyn/context/zip
Comment 10 Frank Becker CLA 2010-04-09 08:25:09 EDT
If you save the dialog with  "more Option" expanded and then open an other Query where the  "more Option" is not expanded you will no longer see the empty space from https://bugs.eclipse.org/bugs/attachment.cgi?id=161883.

Please test this new version.
Comment 11 Steffen Pingel CLA 2010-04-09 13:41:32 EDT
I still get the cut off widgets in Gtk and the widgets in more options are not shown when the section is expanded on open.
Comment 12 Frank Becker CLA 2010-04-09 16:35:33 EDT
Created attachment 164430 [details]
commited patch

Steffen,

please try this!
Comment 13 Frank Becker CLA 2010-04-09 16:35:36 EDT
Created attachment 164431 [details]
mylyn/context/zip
Comment 14 Steffen Pingel CLA 2010-04-10 14:09:18 EDT
That seems to work. Why is it necessary to set the size twice on the shell?
Comment 15 Frank Becker CLA 2010-04-10 15:31:46 EDT
(In reply to comment #14)
> That seems to work. Why is it necessary to set the size twice on the shell?

That was the only way I found to resolve the problem that sometimes the "more Options" was expanded but all the subcontrols where not drawn.

Dir you know a better way?
Comment 16 Steffen Pingel CLA 2010-05-18 16:07:03 EDT
Frank, please also remove the margin of the More Options composite, it's slightly indented.
Comment 17 Shawn Minto CLA 2010-05-19 11:16:05 EDT
Created attachment 169138 [details]
screenshot

When I open the search page and then I expand more options, you can see that the size isn't correct and therefore the controls under more options are cut off on the right.  Also, the list boxes in the more options are extremely hard to use since they only show 2 items.  Maybe we sould at least show 4?
Comment 18 Frank Becker CLA 2010-05-20 14:26:12 EDT
(In reply to comment #16)
> Frank, please also remove the margin of the More Options composite, it's
> slightly indented.
Sorry I did not find a way to fix this.

(In reply to comment #17)
> Created an attachment (id=169138)
> screenshot
> 
> When I open the search page and then I expand more options, you can see that the
> size isn't correct and therefore the controls under more options are cut off on
> the right.  Also, the list boxes in the more options are extremely hard to use
> since they only show 2 items.  Maybe we sould at least show 4?

Changed, please verify.
Comment 19 Steffen Pingel CLA 2010-05-20 18:07:47 EDT
I have tweaked the layout to fix the alignment of controls but a slight inconsistency remains. The right edge of controls in the more options group is still off by a few pixels.
Comment 20 Frank Becker CLA 2010-05-29 09:00:20 EDT
(In reply to comment #19)
> I have tweaked the layout to fix the alignment of controls but a slight
> inconsistency remains. The right edge of controls in the more options group is
> still off by a few pixels.
 Fix for this is now in HEAD.