| Summary: | Bugzilla query dialog opens with wrong sizing | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Tomasz Zarna <tomasz.zarna> | ||||||||||||||||||||
| Component: | Mylyn | Assignee: | Frank Becker <eclipse> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||||||
| Severity: | minor | ||||||||||||||||||||||
| Priority: | P3 | CC: | eclipse, robert.elves | ||||||||||||||||||||
| Version: | dev | ||||||||||||||||||||||
| Target Milestone: | 3.4 | ||||||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||||||
| OS: | Windows XP | ||||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
Frank, can the dialog be resized to better fit the collapsed state here? Created attachment 164282 [details]
commited patch
Created attachment 164283 [details]
mylyn/context/zip
Fix is in HEAD The fix does not work too well for me the dialog still comes up too small (see screenshot). Created attachment 164306 [details]
screenshot
I also don't think it's the right fix to make the dialog smaller. The list boxes should scale to the size of the dialog instead but that is tracked on bug 305568. Frank, can you try mirroring the behavior of the search dialog? It only packs the dialog if the saved dialog size is too small to show all widgets. Created attachment 164360 [details]
commited patch
For the Mac OS this looks fine.
Created attachment 164361 [details]
mylyn/context/zip
If you save the dialog with "more Option" expanded and then open an other Query where the "more Option" is not expanded you will no longer see the empty space from https://bugs.eclipse.org/bugs/attachment.cgi?id=161883. Please test this new version. I still get the cut off widgets in Gtk and the widgets in more options are not shown when the section is expanded on open. Created attachment 164430 [details]
commited patch
Steffen,
please try this!
Created attachment 164431 [details]
mylyn/context/zip
That seems to work. Why is it necessary to set the size twice on the shell? (In reply to comment #14) > That seems to work. Why is it necessary to set the size twice on the shell? That was the only way I found to resolve the problem that sometimes the "more Options" was expanded but all the subcontrols where not drawn. Dir you know a better way? Frank, please also remove the margin of the More Options composite, it's slightly indented. Created attachment 169138 [details]
screenshot
When I open the search page and then I expand more options, you can see that the size isn't correct and therefore the controls under more options are cut off on the right. Also, the list boxes in the more options are extremely hard to use since they only show 2 items. Maybe we sould at least show 4?
(In reply to comment #16) > Frank, please also remove the margin of the More Options composite, it's > slightly indented. Sorry I did not find a way to fix this. (In reply to comment #17) > Created an attachment (id=169138) > screenshot > > When I open the search page and then I expand more options, you can see that the > size isn't correct and therefore the controls under more options are cut off on > the right. Also, the list boxes in the more options are extremely hard to use > since they only show 2 items. Maybe we sould at least show 4? Changed, please verify. I have tweaked the layout to fix the alignment of controls but a slight inconsistency remains. The right edge of controls in the more options group is still off by a few pixels. (In reply to comment #19) > I have tweaked the layout to fix the alignment of controls but a slight > inconsistency remains. The right edge of controls in the more options group is > still off by a few pixels. Fix for this is now in HEAD. |
Created attachment 161883 [details] Edit Repo Query dialog I20100311-1616 + Mylyn 3.4.0.I20100308-0400-e3x I've got an old bugzilla query in my Task list. Today I wanted to update it and this is what I saw (see the screenshot). Expanding the "more Options" group fixes the problem.