Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 30550

Summary: [Team] ValidEdit -- filtering out writeable files
Product: [Eclipse Project] Platform Reporter: Kevin McGuire <Kevin_McGuire>
Component: TeamAssignee: Platform-VCM-Inbox <platform-vcm-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: enhancement    
Priority: P3 CC: dj.houghton, jed.anderson, jeem
Version: 2.1   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:

Description Kevin McGuire CLA 2003-01-29 16:55:00 EST
This was from bug #28216  

It would be handy for callers if they could 
always call validEdit regardless of whether file was read-only or not.  This 
is easy to achieve on the part of the VCM code -- we could filter out all 
resources which are read-only before forwarding them off to the provider.  
This change can be made in a backwards compatible, non-API breaking way.  
However, there is a slight performance hit, since checking read-only is 
expensive, we will be in a position where both the caller and VCM (and likely 
the provider too) are all checking the read-only status of the same file.

--- 

If the caller providers a mix of read-only and writeable files, and if the 
read-only file fails checkout, then the entire operation will need to be 
failed, including the writeable ones.

If the caller is ok with this all or none semantics, then they don't need to 
filter.

Recommend:
1. we filter out writeable files and don't call the provider.  A good provider 
would ignore these anyway, but this guarantees it without creating work for 
the provider.

2. we return an OK status for each writeable file

3. we change the spec or doc to make it clear to the caller that they can call 
with writeable files
Comment 1 Jean-Michel Lemieux CLA 2004-06-11 16:51:03 EDT
Post 3.0
Comment 2 Michael Valenta CLA 2006-06-14 09:22:19 EDT
We do not plan on addessing this item.