Bugzilla – Full Text Bug Listing
| Summary: | [commands] Most MICommands set parameters as options | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc Khouzam <marc.khouzam> | ||||||
| Component: | cdt-debug-dsf-gdb | Assignee: | Marc Khouzam <marc.khouzam> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Marc Khouzam <marc.khouzam> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | pawel.1.piech | ||||||
| Version: | 6.0 | Flags: | marc.khouzam:
review?
(pawel.1.piech) |
||||||
| Target Milestone: | 7.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 160935 [details]
Final fix
This is the patch I committed to HEAD. All JUnit tests pass for GDB 6.8 on Linux.
Pawel, does this make sense to you? |
Created attachment 160888 [details] Fix The MICommand class copied from CDI has the following constructor: public MICommand(IDMContext ctx, String operation, String[] options) but in CDI it was public MICommand(IDMContext ctx, String operation, String[] params) since we copied most MICommands from CDI, all the ones that use this constructor mistakenly set parameters as options. This patch reverts the constructor to what it was for CDI, and cleans up some MI commands that didn't set options/parameters properly. I have to run a few tests and the JUnit tests before committing.