Bugzilla – Full Text Bug Listing
| Summary: | [eclipse-build] [debian] The SDK source contains precompiled class files | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] Linux Tools | Reporter: | Benjamin Drung <bdrung> | ||||||||||||||||||
| Component: | eclipse-build | Assignee: | Krzysztof Daniel <krzysztof.daniel> | ||||||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||||
| Severity: | normal | ||||||||||||||||||||
| Priority: | P3 | CC: | akurtakov, linux.packagingtools-inbox, niels, overholt | ||||||||||||||||||
| Version: | unspecified | ||||||||||||||||||||
| Target Milestone: | 1.0 | ||||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||||
| OS: | Linux | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Bug Depends on: | 304710, 319476, 319478, 319479 | ||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Created attachment 160382 [details]
build-source.patch
Here is a patch for building the source tarball without the .class files.
Do these class files automatically get re-built if we remove them? I've spent a few minutes trying to find the reasons for these .class files being included. My findings are below. org.eclipse.jdt.core/scripts - no idea; been there for 3 or 4 years org.eclipse.core.runtime.compatibility.registry - bug #138376 seemed related but I don't think so; been there for 4 years (bug #126344 also seems related) org.eclipse.osgi.util - bug #189371 seems related; been there for at least a year in its current state (bug #253243 seems related) org.eclipse.osgi.services - bug #189371 seems related; been there for 4 years Created attachment 160628 [details]
build-source2.patch
We can remove the source in:
plugins/org.eclipse.jdt.core/scripts/
plugins/org.eclipse.osgi.util/
We have to adjust eclipse-build for the class files in:
plugins/org.eclipse.osgi.services/
plugins/org.eclipse.core.runtime.compatibility.registry/classes/org/eclipse/core/runtime/
Attached the patch that should be applied once the build issues are resolved.
Okay, I will do nothing here until we're sorted on being able to re-build. After a complete review, I found plugins/org.eclipse.swt/components/external.xpt and some .cvsignore files. After looking at this page: https://developer.mozilla.org/en/XPIDL/xpidl and seeing that xpidl is built as part of the Mozilla build, I don't think we'll be able to make that a build requirement of eclipse-build. Does Debian ship xpidl? Does Ubuntu? I'll get rid of the .cvsignore files in buildSDKSource.sh. Thanks. Created attachment 161034 [details]
remove-cvs.patch
Yes, Debian and Ubuntu ships xpidl. IIRC it's in the xulrunner-dev package, on which we already depend.
Attached the patch for removing the .cvsignore files.
.cvsignore files removed from tarball (before your patch, sorry :)).
I'll work on re-building the .xpt file. Note to self: Debian keeps xpidl in /usr/lib/xulrunner-1.9.1/xpidl (xulrunner-dev package) and Fedora in %{_libdir}/xulrunner-1.9.1/xpidl (xulrunner-devel package).
Note: You can rebuild the .xpt file with this command: $(pkg-config --variable=sdkdir libxul | sed "s/-devel//")/xpidl -m typelib -I $(pkg-config --variable=idldir libxul)/unstable/ -e external.xpt external.idl Benjamin, please file a separate bug so we can track the .xpt issue. It would be best if SWT were to build this themselves. I suggest something like (pseudo-code): buildXpt=false ... if ($buildXpt) build it I think org.eclipse.swt/Eclipse SWT PI/gtk/library/build.sh is the best place for it. The SWT team will know best. AFAIK there is nothing I can do on this bug ATM. This bug is also not targetted for 0.5. Created attachment 162120 [details]
clean-source.patch
Here's the patch that we use for creating our source tarball.
Created attachment 162270 [details]
compile-xpt.patch
Here is the patch for compiling the .xpt file (if it does not exit).
(In reply to comment #14) > Created an attachment (id=162270) [details] > compile-xpt.patch > > Here is the patch for compiling the .xpt file (if it does not exit). Please propose the patch to the SWT component. I posted the patch to bug ~305569. Created attachment 173962 [details]
clean-source2.patch
I moved the compile-xpt.patch to the separate bug ~319479. Attached the updated patch to clean the SDK source. You have to apply the patches from bug ~304710, ~319479, ~319476, and ~319478 first.
Created attachment 173973 [details]
clean-source3.patch
Updated clean source patch.
Adding dependencies on other bugs. I will look at this when those are closed. plugins/org.eclipse.osgi.util/ plugins/org.eclipse.osgi.services/ are clean now. I should have closed this bug yet. commit 971faa77f78c862f5b938ff6800eb2a15698dc7d no class files anymore. |
Created attachment 160372 [details] classfiles.list The SDK source contains precompiled class files: plugins/org.eclipse.jdt.core/scripts/*.class plugins/org.eclipse.core.runtime.compatibility.registry/classes/org/eclipse/core/runtime/IPluginDescriptor.class plugins/org.eclipse.osgi.util/ plugins/org.eclipse.osgi.services/ A complete list of class files is attached. These files should be removed from the tarball and regenerated on build time.