Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 303147

Summary: Trivial warnings cleanup
Product: [Tools] GEF Reporter: Anthony Hunter <ahunter.eclipse>
Component: GEF-Legacy GEF (MVC)Assignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.6   
Target Milestone: 3.6.0 (Helios) M6   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Anthony Hunter CLA 2010-02-17 22:57:58 EST 
There are a bunch of warnings that should be cleaned up.

First one is of the type:

The serializable class ParallelActivity does not declare a static final serialVersionUID field of type long

There is an Eclipse quickfix to generate the field to resolve this warning.
Comment 1 Anthony Hunter CLA 2010-02-17 23:05:26 EST 
The field IWorkbenchActionConstants.DELETE is deprecated	
Replace with ActionFactory.DELETE.getId()
Comment 2 Anthony Hunter CLA 2010-02-17 23:06:43 EST 
(In reply to comment #1)
> The field IWorkbenchActionConstants.DELETE is deprecated    
> Replace with ActionFactory.DELETE.getId()

Also applies to UNDO, REDO, etc...
Comment 3 Anthony Hunter CLA 2010-02-17 23:12:30 EST 
The local variable composite is never read.

Remove the unused local variable.
Comment 4 Anthony Hunter CLA 2010-02-17 23:15:27 EST 
The method fireMoved() from the type Figure is deprecated	

call fireFigureMoved() or fireCoordinateSystemChanged() as appropriate.
Comment 5 Anthony Hunter CLA 2010-02-26 12:24:18 EST 
The field InternalFrame.labeledBorder is never read locally
Comment 6 Anthony Hunter CLA 2010-03-03 16:43:05 EST 
The import org.eclipse.gef.palette.PaletteGroup is never used	ShapesEditorPaletteFactory
Comment 7 Anthony Hunter CLA 2010-03-03 16:44:44 EST 
Discouraged access: The field ToggleRulerVisibility_Label from the type GEFMessages is not accessible due to restriction on classpath entry

This just needs a x-friends addition to the MANIFEST in org.eclipse.gef bundle.
Comment 8 Anthony Hunter CLA 2010-03-04 23:08:23 EST 
The import org.eclipse.gef.tools.DirectEditManager is never used	LogicLabelEditPart

The serializable class WireBendpoint does not declare a static final serialVersionUID field of type long
Comment 9 Anthony Hunter CLA 2010-03-08 12:59:47 EST 
The field ListItemBorder.enabled is never read locally

The method addChild(EditPart) from the type DragEditPartsTrackerTest.TestGraphicalEditPart is never used locally
Comment 10 Anthony Hunter CLA 2010-03-12 14:48:12 EST 
The GEF build now reports zero warnings.