Bugzilla – Full Text Bug Listing
| Summary: | WST server discovery service lookup problem | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | John Arthorne <john.arthorne> | ||||||
| Component: | wst.server | Assignee: | Angel Vera <arvera> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Angel Vera <arvera> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | david_williams, deboer, thomas | ||||||
| Version: | unspecified | Keywords: | plan | ||||||
| Target Milestone: | 3.2 M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| See Also: | https://git.eclipse.org/r/108868 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
John Arthorne
Created attachment 158765 [details]
Potential fix
Thomas can you take a quick look at the patch to double-check it? I'm worried I reported this bug in the wrong place. To be clear this WST code will fail when running against platform build I20100216 or greater without this patch being released. (In reply to comment #3) John, this is the right place, I been busy with other stuff, and haven't had a chance to address this problem. I should be able to look at before WTP adopts that level of platform, which is hopefully not before the end of this week. We will adopt a recent I build on Friday, and ... since Angle and I talked about it today via IM ... there will be a compile break, if not fixed before adoption It centers around _ IPlanner _ becoming API so old provisional API is gone. I think this issue is independent of what this bug is about ... but since all in same are of code, thought I'd document it here. Created attachment 160182 [details]
Combined patch for two problems
In case it helps, here is a combined patch for both the planner change and the service lookup change. I have the WST plugin and all of p2 from HEAD in my workspace, and with this patch everything builds fine.
I have committed and released the code to HEAD. But during my testing I got a NPE that needs to be investigated. Exception in thread "Deferred Initialization" java.lang.NullPointerException at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getExistingFeatures(ExtensionUtility.java:156) at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getAllExtensions(ExtensionUtility.java:176) at org.eclipse.wst.server.discovery.internal.wizard.ExtensionComposite.deferredInitialize(ExtensionComposite.java:478) at org.eclipse.wst.server.discovery.internal.wizard.ExtensionComposite$7.run(ExtensionComposite.java:398) The problem seems to be related to not being able to retrieve the profile, when we do: IProfile profile = profileRegistry.getProfile(IProfileRegistry.SELF); John, Iis there an equivalent call for: IProfile profile = profileRegistry.getProfile(IProfileRegistry.SELF) ? From the debugging so far it seems that there is no profiles in the registry. (In reply to comment #8) > Iis there an equivalent call for: IProfile profile = > profileRegistry.getProfile(IProfileRegistry.SELF) ? From the debugging so far > it seems that there is no profiles in the registry. I assume you are debugging in a test workspace launched from Eclipse. Since the test instance hasn't been provisioned by p2 there is no profile for it. In the "Configuration" tab of your launch configuration, check off "Support software installation in the launched application". This will cause a profile to be spoofed up by PDE to match the target platform. Even though the changes have been committed, there is still something we need look at because are not working. Even after I followed the suggestion of enabling "Support software installation in the launched application" I moving this to M7 to continue the investigation. I am closing this bug as fixed as the changes that were proposed have been integrated. The work that is left is related to bug 305731 New Gerrit change created: https://git.eclipse.org/r/108868 |