Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 302224

Summary: Menus are not made visible
Product: [RT] RAP Reporter: Austin Riddle <austin.riddle>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: holger.staudacher
Version: 1.3   
Target Milestone: 1.3 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Proposed patch none

Description Austin Riddle CLA 2010-02-09 00:24:10 EST 
After updating my workspace to 1.3 HEAD, my application menus stop appearing.  This applies to all menus in all my applications and in all browsers.

I tested with the downloaded release build of 1.3M5 and the menus work fine.

I do have local changes to the RAP codebase but they haven't changed in a long time.

So to me it seems that some post-1.3M5 code in the repo is the culprit or something in my local changes is no longer compatible with the codebase in HEAD.
Comment 1 Ivan Furnadjiev CLA 2010-02-09 03:47:10 EST 
Hi Austin, can you provide a snippet to reproduce it?
Comment 2 Rüdiger Herrmann CLA 2010-02-09 04:11:22 EST 
This is happening with the business/fancy design. "Normal" menus (e.g. new Menu( shell )) are not affected.
Comment 3 Holger Staudacher CLA 2010-02-09 04:26:11 EST 
I think this has something to do with the new MenuBarManager. I tested it with the RAP demo and many other contributions and all works fine. Austin can you please provide a simple demo bundle which creates the affected menu contributions? Thanks...
Comment 4 Holger Staudacher CLA 2010-02-09 04:47:42 EST 
Hi Austin,
I can reproduce the bug, so there is no need for a snippet.
Comment 5 Holger Staudacher CLA 2010-02-09 05:22:38 EST 
The bug also exists without the designs. Steps to reproduce:

1) Start org.eclipse.rap.demo with /rap?startup=default
2) Click on the menu -> nothing happens

I used the latest version from HEAD.
Comment 6 Ivan Furnadjiev CLA 2010-02-09 06:13:49 EST 
Created attachment 158573 [details]
Proposed patch

The order of writing different properties in ShellLCA interferes somehow with menus. writeMode() must be called after writeOpen(). For correct maximize/restore behavior writeMode() must be called before writeBounds() ( ControlLCAUtil.writeChanges ).
Comment 7 Ivan Furnadjiev CLA 2010-02-09 06:30:01 EST 
Applied patch to CVS HEAD. Austin, please reopen if the bug persist.