Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 299437

Summary:

NPEs logged due to bug 295353

Product:

[WebTools] WTP Java EE Tools

Reporter:

Jason Sholl <jsholl>

Component:

jst.j2ee

Assignee:

Jason Sholl <jsholl>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

ccc

Version:

3.0.5

Flags:

cbridgha: review+

Target Milestone:

3.0.5 P

Hardware:

OS:

Windows Server 2003

Whiteboard:

Attachments:

Description	Flags
patch for 3.0.5	none

Description Jason Sholl

2010-01-12 17:15:52 EST

This was introduced by bug 295353 and should also be fixed in the patches stream.

You can reproduce by creating an 5.0 EAR with DD.  Then create a new EJB project with EJB client and adding it to the EAR.  The exception is logged when the EJB client is added.  There are no bad side effects; the exception is simply caught and logged.

!ENTRY com.ibm.etools.javaee.core 4 0 2009-11-24 10:14:16.984
!MESSAGE 
!STACK 0
java.lang.NullPointerException
	at org.eclipse.jst.j2ee.application.internal.operations.AddComponentToEnterpriseApplicationOp$1.run(Unknown Source)
	at com.ibm.etools.javaee.model.internal.EAR5ModelProvider.modify(Unknown Source)
	at org.eclipse.jst.j2ee.application.internal.operations.AddComponentToEnterpriseApplicationOp.updateEARDD(Unknown Source)
	at org.eclipse.jst.j2ee.application.internal.operations.AddComponentToEnterpriseApplicationOp.execute(Unknown Source)
	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl$1.run(Unknown Source)
	at org.eclipse.core.internal.resources.Workspace.run(Unknown Source)
	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.runOperation(Unknown Source)
	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.runOperation(Unknown Source)
	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.doExecute(Unknown Source)
	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.executeImpl(Unknown Source)
	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.cacheThreadAndContinue(Unknown Source)
	at org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl.execute(Unknown Source)
	at org.eclipse.jst.j2ee.ejb.project.facet.EjbFacetPostInstallDelegate.runAddClientToEAROperation(Unknown Source)
	at org.eclipse.jst.j2ee.ejb.project.facet.EjbFacetPostInstallDelegate.execute(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.events.internal.LegacyEventHandlerAdapter.handleEvent(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.events.internal.ProjectListenerRegistry.notifyListeners(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.notifyListeners(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.modifyInternal(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.mergeChangesInternal(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.access$2(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject$5.run(Unknown Source)
	at org.eclipse.core.internal.resources.Workspace.run(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.mergeChanges(Unknown Source)
	at org.eclipse.wst.common.project.facet.core.internal.FacetedProjectWorkingCopy.commitChanges(Unknown Source)
	at org.eclipse.wst.common.project.facet.ui.ModifyFacetedProjectWizard.performFinish(Unknown Source)
	at org.eclipse.wst.web.ui.internal.wizards.NewProjectDataModelFacetWizard.performFinish(Unknown Source)
	at org.eclipse.wst.common.project.facet.ui.ModifyFacetedProjectWizard$3.run(Unknown Source)
	at org.eclipse.core.internal.resources.Workspace.run(Unknown Source)
	at org.eclipse.wst.common.project.facet.ui.ModifyFacetedProjectWizard$4.run(Unknown Source)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(Unknown Source)

Comment 1 Jason Sholl

2010-01-12 17:17:26 EST

Created attachment 155935 [details]
patch for 3.0.5

Comment 2 Chuck Bridgham

2010-01-12 17:19:50 EST

approved

Comment 3 Jason Sholl

2010-01-14 15:02:11 EST

checked into 31M.  This was already fixed in 32, so no change is needed there.

Comment 4 Carl Anderson

2010-01-22 10:30:56 EST

Committed to R3_0_5_patches.