Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 297923

Summary: [patch] selection items appear in the wrong layout when right to left orientation is chosen
Product: z_Archived Reporter: elhanan Maayan <elh.mailgate>
Component: MylynAssignee: Project Inbox <mylyn-triaged>
Status: CLOSED MOVED QA Contact:
Severity: major    
Priority: P2 CC: shawn.minto, steffen.pingel
Version: unspecifiedKeywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
this also happens in other combos
none
after some testing
none
fix for Right to left issue none

Description elhanan Maayan CLA 2009-12-16 01:45:02 EST 
after upgrading to mylyn 3.3.1 no selection  box (like date and combos) are displayed in the right place.
this is after using eclipse in -nl he
Comment 1 elhanan Maayan CLA 2009-12-16 01:47:04 EST 
Created attachment 154539 [details]
this also happens in other combos

enclosed an example of the combo of dates
Comment 2 Steffen Pingel CLA 2009-12-16 03:07:53 EST 
Shawn, let's take a look at that together.
Comment 3 Steffen Pingel CLA 2010-01-09 02:54:48 EST 
I can confirm that this is reproducable on Linux/Gtk with Eclipse 3.6M4.
Comment 4 elhanan Maayan CLA 2010-01-09 12:02:31 EST 
check out the difference between 3.3.0 and 3.3.1 in mylyn, that's when it started to go wrong.
Comment 5 elhanan Maayan CLA 2010-12-03 08:58:22 EST 
i believe the issue is in AbstractInPlaceDialog constructor where it calculcates bounds.

doing this:
	bounds = openControl.getParent().getBounds();
			Point absPosition = openControl.getParent().toDisplay(openControl.getLocation());
			bounds.x = absPosition.x - bounds.x;
			bounds.y = absPosition.y + bounds.y;
Comment 6 elhanan Maayan CLA 2010-12-03 09:03:32 EST 
Created attachment 184464 [details]
after some testing
Comment 7 elhanan Maayan CLA 2010-12-04 11:50:18 EST 
Created attachment 184535 [details]
fix for Right to left issue

this is not the fix i originally wanted, but i dont have access to the form's toolkit so at least if the entire application will be in rtl, it will match
Comment 8 Steffen Pingel CLA 2011-01-04 14:02:41 EST 
Thanks for the patch. Shawn, what are your thoughts?
Comment 9 Steffen Pingel CLA 2011-02-26 04:34:27 EST 
We are past the contribution deadline for 3.5. Sorry I missed this. Moving to the next release cycle.
Comment 10 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn