Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 297901

Summary: Scrollbar needs to be fixed
Product: [Modeling] GMF-Runtime Reporter: Lidija Grahek <lgrahek>
Component: GeneralAssignee: Lidija Grahek <lgrahek>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, lgrahek
Version: 2.2   
Target Milestone: 2.3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 297903    
Bug Blocks:    
Attachments:
Description Flags
Sample of an old scrollbar
none
ListScrollBar Fix
none
ListScrollBar Fix
none
ListScrollBar Fix none

Description Lidija Grahek CLA 2009-12-15 16:14:23 EST
Created attachment 154526 [details]
Sample of an old scrollbar

Current scroll bar as defined in org.eclipse.gmf.runtime.draw2d.ui.figures.ListScrollBar has visual issues.

1. There are bugs related to showing the icons on arrow buttons: they show as green when disabled (instead of grey), and don't show at all when enabled except when mouse hovers above. 

2. Styles of the arrow buttons and scroll thumb are not optimal: shadow on the buttons is too thick making them striking, border of the thumb is sunken and there is no feedback making it easier to spot and use. 

3. Whole scrollbar area is semi-transparent. The goal was to increase visible client area, but the chances are that you will have to scroll anyway if you want to see something underneath this semi-transparent bar. So this is just making scroll pane look more clutterred and less visually pleasing.

A screenshot is attached showing these issues.
Comment 1 Lidija Grahek CLA 2009-12-15 16:52:36 EST
Created attachment 154531 [details]
ListScrollBar Fix

Attached the patch that fixes the issues with ListScrollBar.
Comment 2 Lidija Grahek CLA 2009-12-18 12:31:30 EST
Created attachment 154797 [details]
ListScrollBar Fix
Comment 3 Lidija Grahek CLA 2009-12-18 18:27:09 EST
Created attachment 154827 [details]
ListScrollBar Fix

I also fixed the issue where 1px of horizontal bar remains visible after collapsing compartment (ResizableCompartmentFigure)
Comment 4 Lidija Grahek CLA 2009-12-18 18:28:23 EST
Committed to gmf-head.
Comment 5 Eclipse Webmaster CLA 2010-07-16 23:38:04 EDT
[target cleanup] 2.3 M5 was the original target milestone for this
bug
Comment 6 Eclipse Webmaster CLA 2010-07-19 21:57:16 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug