| Summary: | Scrollbar needs to be fixed | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] GMF-Runtime | Reporter: | Lidija Grahek <lgrahek> | ||||||||||
| Component: | General | Assignee: | Lidija Grahek <lgrahek> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | ahunter.eclipse, lgrahek | ||||||||||
| Version: | 2.2 | ||||||||||||
| Target Milestone: | 2.3 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | |||||||||||||
| Bug Depends on: | 297903 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 154531 [details]
ListScrollBar Fix
Attached the patch that fixes the issues with ListScrollBar.
Created attachment 154797 [details]
ListScrollBar Fix
Created attachment 154827 [details]
ListScrollBar Fix
I also fixed the issue where 1px of horizontal bar remains visible after collapsing compartment (ResizableCompartmentFigure)
Committed to gmf-head. [target cleanup] 2.3 M5 was the original target milestone for this bug [GMF Restructure] Bug 319140 : product GMF and component Runtime was the original product and component for this bug |
Created attachment 154526 [details] Sample of an old scrollbar Current scroll bar as defined in org.eclipse.gmf.runtime.draw2d.ui.figures.ListScrollBar has visual issues. 1. There are bugs related to showing the icons on arrow buttons: they show as green when disabled (instead of grey), and don't show at all when enabled except when mouse hovers above. 2. Styles of the arrow buttons and scroll thumb are not optimal: shadow on the buttons is too thick making them striking, border of the thumb is sunken and there is no feedback making it easier to spot and use. 3. Whole scrollbar area is semi-transparent. The goal was to increase visible client area, but the chances are that you will have to scroll anyway if you want to see something underneath this semi-transparent bar. So this is just making scroll pane look more clutterred and less visually pleasing. A screenshot is attached showing these issues.