Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 297616

Summary: Import of INQLE Google Visualizations Project into RAP Incubator
Product: [RT] RAP Reporter: Austin Riddle <austin.riddle>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: b.muskalla, caniszczyk, dd
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Google Visualizations RAP Bundles none

Description Austin Riddle CLA 2009-12-11 13:50:57 EST
Based on conversations starting here:

http://dev.eclipse.org/mhonarc/lists/rap-dev/msg00522.html

the custom RAP widgets for Google Visualizations should be sourced in the RAP incubator.
Comment 1 Chris Aniszczyk CLA 2009-12-12 13:53:03 EST
Can you attach the refactored EPL source to this bug?
Comment 2 Austin Riddle CLA 2009-12-14 18:00:58 EST
(In reply to comment #1)
> Can you attach the refactored EPL source to this bug?

I am working on it. 
I have finished the refactoring. I need to figure out that the source file copyrights should say.  Some are blank, some say Innoopract, but none say inqle or David Donahue.  I need to clear this up with him...waiting on his response.

Do you have any advice on that?

I have also included some of my own improvements:

1. Motion chart 'state' parameter listening and setting
2. Auto-resize for all the visualizations (previously, when the java composite counterpart resized it did not resize the flash content).
3. About_files content with license info for Google, etc.

I will upload soon, just need to get the correct copyrights.

Cheers!
Comment 3 Chris Aniszczyk CLA 2009-12-14 19:09:03 EST
Our general policy is to keep the existing copyrights unless agreement was reached to change everything to some new license (in this case, EPL).

I would post what you initially have and let the Eclipse legal team sift through anything major.
Comment 4 Austin Riddle CLA 2009-12-15 10:18:32 EST
Here is a copy of an email I received from David Donahue:
------------------
Austin,
I started with the example code from Eclipse RAP documentation on how
to make a RAP widget.  That must be how the copyright statements got
in there.  Inoopract did not write the code for this widget, I did. I
suspect those Inoopract copyright bits should not be there.

I am not sure why I copied code from json.org to package
org.inqle.json.  I recall tinkering with the code slightly to get
dates to work w/ Google API but not sure if I needed to modify the
JSON code base in the end.
Definitely code in this package belongs to json.org.

I hope this is enough info for you.  Thanks again for taking ownership.
Best,
Dave Donohue
---------------------
On Mon, Dec 14, 2009 at 2:47 PM, Austin Riddle <austin.riddle@tamu.edu> wrote:
> Hello David,
> 
> I am in the process of refactoring the google viz. code and wanted to know
> who the copyright holder is.
> Most, if not all of the classes have Innoopract as the copyright holder.
> 
> Could you please let me know the correct owner so that I can update the
> copyright mesgs?
> 
> Thanks,
> 
> Austin Riddle
Comment 5 Austin Riddle CLA 2009-12-16 14:58:52 EST
Created attachment 154590 [details]
Google Visualizations RAP Bundles

Please find attached the inqle google visualizations project refactored for hosting in the RAP incubator.

The attachment contains the following:

 * 2 bundles - widgets and demo
 * Enhancements to the project that I described in a previous post
 * Corrected copyrights as indicated by David Donahue.

I am sure there will need to be some refinement before actual check-in, but I am not sure what the next step is since (being an incubator-only committer) I seem to be unable to create/manage any CQs or IP log information.

Let me know what needs to be done next.
Comment 6 Austin Riddle CLA 2010-01-27 12:26:51 EST
The Eclipse IP Team requests the following confirmations from David Donahue:

1.  Contributor to confirm he authored 100% of the content 
2.  Contributor to confirm he has the rights to donate the content to Eclipse
3.  Contributor to confirm he contributes the content under the EPL

David please indicate your affirmative to these statements in a post to this bug.

Thanks.
Comment 7 Chris Aniszczyk CLA 2010-01-27 12:42:00 EST
What's the CQ btw?
Comment 8 Austin Riddle CLA 2010-01-27 12:45:06 EST
(In reply to comment #7)
> What's the CQ btw?

http://dev.eclipse.org/ipzilla/show_bug.cgi?id=3717
Comment 9 David Donohue CLA 2010-01-27 13:31:02 EST
I authored 100% of this content.
I have the rights to donate this content to Eclipse.
I am donating this content under the EPL.

Thanks for the great work Austin!
Best,
David Donohue
Comment 10 Austin Riddle CLA 2010-02-03 14:39:05 EST
Initial check-in has been performed.

Until the JSON code is checked into Orbit as a separate bundle, it will remain in this contribution's core bundle.  What remains is to add the proper about file content regarding JSON.
Comment 11 Benjamin Muskalla CLA 2010-02-04 06:47:37 EST
Awesome work Austin! Can we now close this bug?
Comment 12 Austin Riddle CLA 2010-02-04 10:01:41 EST
(In reply to comment #11)
> Awesome work Austin! Can we now close this bug?

Thanks Ben,

I think we can close this bug. 

For easier referencing, here are all the CQs involved with this bug:

CQ 3717 - EPL code
CQ 3739 - JSON piggyback
CQ 3765 - Google Dependency

Should we notify the newsgroup?
Comment 13 Benjamin Muskalla CLA 2010-02-04 10:39:24 EST
As the widge is now part to the incubator, I'll close this bug. Thanks again to David and Austin!

Regarding the newsgroup: Sounds like an good idea to me, just go ahead and announce it there.