Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 297368

Summary: Would like to suppress gridlines in excel output
Product: z_Archived Reporter: Steve Schafer <sschafer>
Component: BIRTAssignee: JingwenShen <jingwen.shen>
Status: VERIFIED FIXED QA Contact: Xiaodan Wang <xwang>
Severity: enhancement    
Priority: P3 CC: hustlg, jingwen.shen, jouyang, scottr, wenfeng.fwd
Version: unspecifiedKeywords: helpwanted
Target Milestone: 2.6.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard: Non-Auto
Attachments:
Description Flags
org.eclipse.birt.report.engine.emitter.excel.layout.ExcelContext
none
org.eclipse.birt.report.engine.emitter.excel.ExcelEmitter
none
org.eclipse.birt.report.engine.emitter.excel.ExcelXmlWriter
none
org.eclipse.birt.report.engine.api.IExcelRenderOption none

Description Steve Schafer CLA 2009-12-09 12:42:21 EST
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091109 Ubuntu/9.10 (karmic) Firefox/3.5.5
Build Identifier: M20090917-0800

In the Excel XML file it's possible to add an option to 
suppress gridline display.  It would be nice to be able to
specify this somewhere in the report or perhaps in the
RenderOptions to cause the Excel emitter to set this option.


Reproducible: Always
Comment 1 Wenfeng Li CLA 2010-02-09 17:17:56 EST
set to future until there is volunteer to add this enhancement.
Comment 2 Steve Schafer CLA 2010-02-18 15:24:01 EST
I can volunteer for this.  How does this work if I'm not a committer?
Comment 3 Wenfeng Li CLA 2010-02-18 16:35:10 EST
(In reply to comment #2)
> I can volunteer for this.  How does this work if I'm not a committer?

steve, You can attach code to this bugzilla.  Thanks for the help.
Comment 4 Steve Schafer CLA 2010-05-24 12:34:52 EDT
Created attachment 169696 [details]
org.eclipse.birt.report.engine.emitter.excel.layout.ExcelContext

Changed to enable hiding gridlines
Comment 5 Steve Schafer CLA 2010-05-24 12:36:00 EDT
Created attachment 169697 [details]
org.eclipse.birt.report.engine.emitter.excel.ExcelEmitter

Changed to enable hiding gridlines
Comment 6 Steve Schafer CLA 2010-05-24 12:36:43 EDT
Created attachment 169698 [details]
org.eclipse.birt.report.engine.emitter.excel.ExcelXmlWriter

Changed to enable hiding gridlines
Comment 7 Steve Schafer CLA 2010-05-24 12:37:44 EDT
Created attachment 169699 [details]
org.eclipse.birt.report.engine.api.IExcelRenderOption

Changed to add constant for render option for hiding gridlines
Comment 8 Steve Schafer CLA 2010-05-24 12:40:20 EDT
I've attached four files I changed to allow hiding gridlines in excel output triggered by a new render option: excelRenderOption.hideGridlines.   My changes were based on BIRT 2.5.2 release 201002101801.  I've tested this with a custom report-runner plugin I wrote.  I did not include that code because it's rather lengthy.  Let me know if there's anything else I can do.
Comment 9 Steve Schafer CLA 2010-05-24 12:41:30 EDT
Forgot to mention that you can find the changes by searching for "Schafer".
Comment 10 Scott Rosenbaum CLA 2010-05-24 13:39:04 EDT
+1 to add this.
Comment 11 JingwenShen CLA 2010-05-26 02:34:04 EDT
Hi Steve,

I have committed the changed code to cvs, and the problem has been fixed.
Thanks very much for your help!

-Jingwen
Comment 12 Xiaodan Wang CLA 2010-05-27 02:20:15 EDT
IExcelRenderOption.HIDE_GRIDLINES=false by default, when IExcelRenderOption.HIDE_GRIDLINES=true, the gridlines are not shown.

Verified in build (2.6.0.v20100526-0630).