Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 297187

Summary:	UI polish for Delete Plug-in Projects dialog
Product:	[Eclipse Project] PDE	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	VERIFIED FIXED	QA Contact:
Severity:	trivial
Priority:	P3	CC:	ankur_sharma, curtis.windatt.public, daniel_megert, darin.eclipse
Version:	3.6
Target Milestone:	3.6 M5
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:
Bug Depends on:	297232
Bug Blocks:

Description Markus Keller

2009-12-08 07:30:32 EST

I20091207-1800

UI polish for Delete Plug-in Projects dialog from bug 18500:
- filter text field should have initial focus
- "Projects to delete:" should have a mnemonic (&P)

Comment 1 Curtis Windatt

2009-12-08 09:47:50 EST

I was unsure about the initial focus as previously the overwrite dialog would select Yes by default if the user hit enter.  With the filter text having focus, hitting enter does nothing.  I can easily live with either.

cc'ing Darin and Ankur so they can comment with their thoughts after testing.

Comment 2 Markus Keller

2009-12-08 11:32:41 EST

I see. The underlying issue is that FilteredTree catches the Enter key (I opened bug 297232 for that).

Dani, could you also live with a consistent UI (i.e. needs 2x Enter until bug 297232 is fixed)?

Comment 3 Curtis Windatt

2009-12-08 11:48:55 EST

Fixed.  Filter text selected by default, mnemonic fixed.  Will keep an eye on bug 297232.

Comment 4 Dani Megert

2009-12-09 08:09:23 EST

>Dani, could you also live with a consistent UI (i.e. needs 2x Enter until bug #
>297232 is fixed)?
Yes.

Comment 5 Dani Megert

2009-12-10 05:23:09 EST

>Fixed.  Filter text selected by default, mnemonic fixed.
This is not fixed in I20091209-1800.

Comment 6 Dani Megert

2009-12-10 07:17:47 EST

Why is this now 3.6? Isn't the fix in place but maybe the map file was not updated?

Comment 7 Curtis Windatt

2009-12-10 11:01:06 EST

The filter text is selected by default in I20091209-1800 but the mnemonic was missing.  The mnemonic was not committed when tagging happened (though all the other NLS strings were, so not sure what happened there).  Will retag to include in today's rebuild.

Comment 8 Dani Megert

2009-12-10 11:10:59 EST

>The filter text is selected by default in I20091209-1800
I don't know how/what you tested but this is not the case.

Comment 9 Curtis Windatt

2009-12-10 11:20:53 EST

Interesting, works fine on linux, doesn't work in Win XP

Comment 10 Markus Keller

2009-12-10 12:20:56 EST

Just remove this line from OverwriteProjectsSelectionDialog.createTableArea(Composite):
		fFilteredTree.setFocus();

I've filed bug 297510 for the platform inconsistency.


BTW: The line fFilteredTree.setInitialText(PDEUIMessages.DuplicatePluginResolutionDialog_typeFilerText);
is also unnecessary and should be removed.

Comment 11 Curtis Windatt

2009-12-10 12:56:45 EST

(In reply to comment #10)
> Just remove this line from
> OverwriteProjectsSelectionDialog.createTableArea(Composite):
>         fFilteredTree.setFocus();

Got my new WinXP box up and running and have confirmed that removing the lines as Markus suggested works in both Win XP and linux.

Will leave the fix for M5.

Comment 12 Curtis Windatt

2009-12-14 12:22:48 EST

Fixed in HEAD.

Comment 13 Dani Megert

2009-12-15 03:12:16 EST

Verified in N20091214-2000.