Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 297183

Summary:

[quick fix] "Add unimplemented methods" should add methods from top of hierarchy first

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Assignee:

Markus Keller <markus.kell.r>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

deepakazad, mateusz.wenus, stefan_eggersto, tpollin

Version:

3.6

Keywords:

helpwanted

Target Milestone:

3.6 M5

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Fix	none

Description Markus Keller

2009-12-08 07:12:34 EST

HEAD

(Follow-up to bug 140971 comment 20)
> - "Override/Implement Methods" : For this case the super super class method
> comes first and then super class methods.
> - "Add unimplemented methods" :  Methods from immediate super class comes first
> and then the methods from super super class.
> 
> I prefer the implementation for "Override/Implement Methods" case. And I think
> that both cases should follow the same ordering of methods.

I agree, we should be consistent.

As always, a patch would be welcome ;-).

Comment 1 Markus Keller

2010-01-25 12:45:32 EST

Created attachment 157143 [details]
Fix

Comment 2 Markus Keller

2010-01-25 12:49:43 EST

I actually see the same order in both cases:

With "class DefaultCircle implements Circle" and "interface Circle extends Shape", the methods generated in DefaultCircle are coming from Circle first, and then from Shape. I've reversed the order in HEAD.