Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 297046

Summary:	[EFS] Need support for Undo of partial deletes
Product:	[Eclipse Project] JDT	Reporter:	Girish Baxi <giribaxi>
Component:	UI	Assignee:	JDT-UI-Inbox <jdt-ui-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	deepakazad, giribaxi, john.arthorne, markus.kell.r, raji, Szymon.Brandys
Version:	3.5.1
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description Girish Baxi

2009-12-07 04:04:59 EST

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: 20090925-1604

We have an Eclipse based product which uses EFS extension to implement network based file system that maps to a custom data store. There is a limitation to the code (org.eclipse.ltk.core.refactoring.resource.DeleteResourceChange) that handles the deletion from Eclipse's navigators (say Resource navigators). It can not provice "undo" for partial deletions , e.g. user tries to delete a folder that contains some files, and the custom IFileStore throws an exception for one of the files which user is not allowed to delete, that exception propagates to DeleteResourceChange, however , it doesnt provide an "Undo" when the IResource.delete() throws an exception, as a result, user gets an error dialog that shows "undo" option but nothing happens when user selects it.

Reproducible: Always

Comment 1 Girish Baxi

2009-12-07 04:12:40 EST

Users expect the "Undo" to recover the partial deletes since that button is enabled.

Comment 2 Szymon Brandys

2011-08-16 06:29:23 EDT

Comment 3 Szymon Brandys

2011-08-16 06:31:25 EDT

(In reply to comment #2)
> I
... am moving it to JDT that also owns LTK.

Comment 4 John Arthorne

2011-08-16 11:13:35 EDT

I see two approaches to this bug:

1) It is a request to actually implement Undo support for partial deletions
2) It is a bug report that we shouldn't offer Undo when we can't.

I expect 1) would be quite difficult to implement, but meanwhile I would suggest doing 2). What does Undo even attempt to perform in an error case like this?

Comment 5 Deepak Azad

2011-11-23 06:37:00 EST

(In reply to comment #4)
> I expect 1) would be quite difficult to implement, but meanwhile I would
> suggest doing 2). 
I would agree to this. Markus, thoughts?

Comment 6 Eclipse Genie

2020-05-12 07:58:56 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.