Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 296463

Summary: Sharing a Git project with .git directly below project no longer works
Product: [Technology] EGit Reporter: Robin Rosenberg <robin.rosenberg>
Component: CoreAssignee: Project Inbox <egit.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mn, sop, stefan.lay
Version: unspecified   
Target Milestone: ---   
Hardware: Other   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Screenshot of Sharing wizard none

Description Robin Rosenberg CLA 2009-11-30 08:36:14 EST 
Create a project
Run git init on it outside eclipse
Try to share the project
Nothing happens.
The dialog is also quite hard to understand
Comment 1 Robin Rosenberg CLA 2009-11-30 09:09:26 EST 
This worked in I0.5.0.200908282229 but not in I0.6.0.200911171911
Comment 2 Mykola Nikishov CLA 2009-11-30 10:30:14 EST 
Robin, could you confirm it's not the case described in bug 291303 (3rd comment, and you are not trying to share a git repository nested into another one)? If it is bug 291303's severity should be raised IMHO.

Also please take a look at bug 292592. It seems to me this bug is a duplicate of one of them (or both?).
Comment 3 Mykola Nikishov CLA 2009-11-30 11:11:35 EST 
Robin, I've updated EGit to 0.6.0.200911171911 (available from update site) and tried to share a sample project. I'm almost sure this one is bug 291303: project was shared for a not-nested repository but not for the nested one.
Comment 4 Shawn Pearce CLA 2009-11-30 20:40:07 EST 
Robin, did commit cb9adcf59464fc49a555516039435c45eb6ccb60 fix this?
Comment 5 Stefan Lay CLA 2009-12-02 11:55:36 EST 
Created attachment 153618 [details]
Screenshot of Sharing wizard
Comment 6 Stefan Lay CLA 2009-12-02 11:56:15 EST 
I'm not sure if I face the same issue as Robin, but I also cannot share a project where the repository is in a folder below. I'm on commit efbfafde119eaa2ddd5156e19b1b73485c0f4fa6.

The reason is that I can only select the first column in the table: Because of this I cannot select the row with the entry ../.git in the third column and the Finish button never gets enabled.

There is no nested repository but only one directly below. I used the jgit project to test this (See attached screenshot).
Comment 7 Stefan Lay CLA 2009-12-03 09:23:16 EST 
I found a bug in the ConnectProviderOperation which may cause the problem Robin has posted:

The method findActualRepository of ConnectProviderOperation searches for a RepositoryMapping with the path "..\\.git". However, the RepositoryMapping stores the path with a /: "../.git". 

I posted the fix to http://egit.eclipse.org/r/#change,124.


Regarding the selection problem I found I will create a new Bugzilla entry.

Fruthermore I completely agree with Robin that the dialog is very hard to understand.
Comment 8 Shawn Pearce CLA 2009-12-03 11:38:20 EST 
Committed as 9fd991fcc6c8cde8eda431cfd8a87fa7ff0637f6
Comment 9 Robin Rosenberg CLA 2009-12-07 04:59:56 EST 
(In reply to comment #4)
> Robin, did commit cb9adcf59464fc49a555516039435c45eb6ccb60 fix this?

Yes it did.