Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 296457

Summary:

Problems with new problems and quick fixes for build.properties

Product:

[Eclipse Project] PDE

Reporter:

Markus Keller <markus.kell.r>

Component:

Assignee:

Ankur Sharma <ankur_sharma>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, darin.eclipse

Version:

3.6

Target Milestone:

3.6 M5

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Markus Keller

2009-11-30 07:18:58 EST

N20091129-2000

The new Quick Fixes for build.properties (bug 253950, bug 154292) need some polish:

- Quick fix label should not have a '.' at the end
- 'Add all...' is missing the '+' image

- check out org.eclipse.core.expressions with tag v20090429-1800
=> order of the quick fixes should be predictable (I've seen different order in different workspaces)

- execute quick fix 'Add bin/ to the output.. build entry.'
=> after this, quick fix 'Add all missing java compiler build entries.' is redundant and should not be shown

- revert build.properties to version from CVS
- execute quick fix 'Add all missing java compiler build entries.'
=> only "jre.compilation.profile = J2SE-1.3" got added

=> there's still an error: "The 'jre.compilation.profile' build entry does not match the 'Compiler compliance level' project setting.". That sentence is wrong, since the compiler compliance DOES match the entry. Maybe this is about the EE. Please fix the message or the error detection.

=> the 'Change the value...' quick fix does nothing

Comment 1 Ankur Sharma

2009-11-30 13:31:08 EST

Created attachment 153369 [details]
Patch

all reported problems fixed + small code cleansing

Comment 2 Ankur Sharma

2009-11-30 14:15:15 EST

Fixed in HEAD

Comment 3 Markus Keller

2009-12-02 12:27:53 EST

> - Quick fix label should not have a '.' at the end
This has only been fixed for the 'Add all...' fix, but it actually applies to all subclasses of BuildEntryMarkerResolution (and maybe other fixes).

Rest looks good now, though I didn't verify this in code:
> => order of the quick fixes should be predictable (I've seen different orders
> in different workspaces)

Comment 4 Ankur Sharma

2009-12-04 13:09:42 EST

(In reply to comment #3)
> > - Quick fix label should not have a '.' at the end
> This has only been fixed for the 'Add all...' fix, but it actually applies to
> all subclasses of BuildEntryMarkerResolution (and maybe other fixes).
Fixed. I will give a close look at all the messages in M5. We may have to reword them too.
 
> Rest looks good now, though I didn't verify this in code:
> > => order of the quick fixes should be predictable (I've seen different orders
> > in different workspaces)

The order of quick fixes depends on the sequence of problems. Which sequence of the entries in build.properties. I am assuming you are mentioning about the quick fixes that appear when you click the marker on the left ruler.

Comment 5 Ankur Sharma

2010-01-04 06:33:05 EST

Closing this bug as Fixed after discussing with Markus. Bug 298742 will address the order issue.