Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 296345

Summary:

[EaseOfUse] A new extension point to allow adopters to add additional controls and behaviour to first page of server wizard

Product:

[WebTools] WTP ServerTools

Reporter:

Sheldon Wosnick <swosnick>

Component:

wst.server

Assignee:

Elson Yuen <eyuen7>

Status:

CLOSED FIXED

QA Contact:

Angel Vera <arvera>

Severity:

enhancement

Priority:

CC:

eyuen7, swosnick

Version:

3.2

Keywords:

plan

Target Milestone:

3.2 M5

Flags:

arvera: review+

Hardware:

OS:

Windows XP

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=291120
https://git.eclipse.org/r/108835

Whiteboard:

Attachments:

Description	Flags
v1.0	none
v1.1	none
v1.2	arvera: iplog+

Description Sheldon Wosnick

2009-11-27 09:57:04 EST

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Build Identifier: 3.2

This enhancement is a new extension point that allows adopters to enter additional, use-case specific controls and behaviour on the first page of the current New Server Wizard. It will permit some flexibility to specify where on the page with respect to the other existing controls (server type selector, server name host name field ... etc.) this control set should be laid out, for example, TOP (first control), MIDDLE and BOTTOM (last control). It should provide the notification handling to other controls on the page that need to react to changes in it as well as be able to react to changes in other controls on that page making the communication between the user-defined sections and the existing sections seamless.

Reproducible: Always

Steps to Reproduce:
N/A new api. You would be able to see that the existing api has no framework support for adding new content to the FIRST page of the server wizard. There are ways, by providing wizard fragments to change/modify/add new pages subsequent to the first page, but not the first page itself.

Comment 1 Elson Yuen

2009-11-27 15:18:51 EST

Angel, please assign this one to me.

Comment 2 Elson Yuen

2009-11-27 15:20:44 EST

Created attachment 153275 [details]
v1.0

This patch has the implementation described before by introducing the extension point:
org.eclipse.wst.server.ui.serverCreationWizardPageExtension

Comment 3 Elson Yuen

2009-11-27 16:16:18 EST

Created attachment 153279 [details]
v1.1

Add new hooks to allow adopter to store the custom UI specific information to the server model.

Comment 4 Angel Vera

2009-12-01 17:30:38 EST

The patch looks good. A couple of comments, always check for formating of the code, I found a few places where the formatting didn't follow the conventions (ie. brackets aligning, indentation), other places where an 'import *;' was expanded to multiple imports. Little details, but from a technical point of view the changes make sense.

Comment 5 Angel Vera

2009-12-01 17:36:32 EST

Created attachment 153544 [details]
v1.2

I am attaching the new patch just in case we want to compare the changes that I made

Comment 6 Angel Vera

2009-12-01 17:37:33 EST

Changes committed to HEAD

Comment 7 Angel Vera

2009-12-01 22:03:05 EST

Changes released to HEAD

Comment 8 Angel Vera

2009-12-02 12:29:09 EST

Verified by looking at the code in: http://build.eclipse.org/webtools/committers/wtp-R3.2.0-I/20091202065244/I-3.2.0-20091202065244/

Comment 9 Eclipse Genie

2017-10-11 16:30:19 EDT

New Gerrit change created: https://git.eclipse.org/r/108835