Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 294698

Summary: [analyzer] PathNameCS.simpleNames.ast are awkward to set
Product: [Modeling] OCL Reporter: Ed Willink <ed>
Component: CoreAssignee: OCL Inbox <mdt-ocl-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.0.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Full init of PathNameCS.simpleNames.ast none

Description Ed Willink CLA 2009-11-10 02:26:54 EST 
Replacement of PathNameCS.sequenceOfNames by simpleNames provided some SimpleNameCS.ast pointers initialize.

This requires that every caller of PathNameCS.setAst() to be refined to do more AST initialization.

To minimise ripple, I added the AbstractOclAnalyzer.initPathNameAst() helper and invoked it from AbstractOclAnalyzer.typeCS().

In QVTd I have been steadily identifying call oversights, some in QVTd some in OCL.

It would be much easier if PathNameCS.setAst() just initialized properly.
Comment 1 Ed Willink CLA 2009-11-10 02:34:03 EST 
Created attachment 151776 [details]
Full init of PathNameCS.simpleNames.ast

The patch shows that I accidentally committed a dummy PathNameCSImpl.setAst to assist debugging. This now becomes a real method and the helper is eliminated.
Comment 2 Adolfo Sanchez-Barbudo Herrera CLA 2009-11-10 06:02:00 EST 
It looks ok. +1.

Cheers,
Adolfo.
Comment 3 Ed Willink CLA 2009-11-10 14:14:15 EST 
Committed to CVS HEAD.

Alex: If this missed M3 it doesn't matter.
Comment 4 Ed Willink CLA 2011-05-27 02:48:32 EDT 
Closing after over 18 months in resolved state.