Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 293467

Summary:

[Hotbug] Performance problem when validate managed properties

Product:

[WebTools] Java Server Faces

Reporter:

David Williams <david_williams>

Component:

JSF Tools

Assignee:

jsf inbox <jsf-inbox>

Status:

RESOLVED FIXED

QA Contact:

Cameron Bateman <cameron.bateman>

Severity:

major

Priority:

CC:

raghunathan.srinivasan, robert_gallagher, xiaonan_jiang

Version:

unspecified

Target Milestone:

3.0.5 P

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

293211

Bug Blocks:

Attachments:

Description	Flags
combined patch with all other patches that effect jsf.common	none

Description David Williams

2009-10-27 12:24:09 EDT

+++ This bug was initially created as a clone of Bug #293211 +++

This is a tracking bug to use for requesting the patch a patch for 305 P stream. 

The patch itself is attached to original bug. 

I'm marking as hotbug since in some IBM adopter usage it has been found there are some particular usage patterns (heavy use of managed properties) that make this bug cause the use of JSF/WTP to be prohibitive.

Comment 1 Raghunathan Srinivasan

2009-10-29 14:11:28 EDT

We will review.

Comment 2 David Williams

2009-11-13 08:09:45 EST

Applied fix in bug 293211. Is in patch builds >= P20091113081903. 

Don't forget to apply fix to 3.1.2 and 3.2.0 streams

Comment 3 David Williams

2009-11-13 12:45:40 EST

I've noticed that with that tagged version, we've lost other 305 patches that have been applied previously. 

I know there was some issues or confusions with an R_3_0_5_patches branch, instead of R3_0_5_patches. I think in the attempt to standardize on the normal form of R3_0_5_patches that others were lost. Though not sure R_3_0_5_patches looks quite right either. 

What I do know is the last, known good, tagged version of the jsf.common bundle was v200910042227. 

I compared R3_0_5_patches to that tagged version, and could "pull in" all the previous fixes. One change that's not in a previous patch, is incrementing the manifest.mf file version to 1.1.5.qualifier. (that's what lead me to discover the problem to begin with). 

You can pull in those fixes from previous tag, or re-apply all the patches (and increment version) ... or, I'll attach patch with my best understanding of what should be in patches branch of jsf.common. 


There are 6 bugs that should be in patches branch, only 4 of which effect the jsf.common bundle (jsf.core looks fine, btw). 

bug 290412
bug 290543
bug 293467
bug 290738

bug 290739 
bug 290832

Comment 4 David Williams

2009-11-13 12:50:24 EST

Created attachment 152178 [details]
combined patch with all other patches that effect jsf.common

Let me know if questions or issues, but bottom line for reference are the bugs marked with 305P target. 

I would, btw, encourage "fixing" the branch to R3_0_5_patches, instead of trying to revert to R_3_0_5_patches (if that's indeed what happened) since it will then "match" the branch name used for jsf.core, and be more consistent, so I think less confusing 3 months from now when we ask for another patch. :)

Comment 5 Raghunathan Srinivasan

2009-11-13 16:23:05 EST

Applied the attached patch to R3_0_5_patches. Tagged as v200911131325 .

Thanks David

Comment 6 David Williams

2009-11-14 01:53:35 EST

Things look back to normal now. Much thanks.