Bug 293379

Description Phil Xue 2009-10-26 20:54:23 EDT

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier: 1.3.0.20090929-1121

The extension point (org.eclipse.rap.ui.decorators) that org.eclipse.ui.internal.decorators.DecoratorManager#getExtensionPointFilter() looks up does not exist. I suspect that it's got mixed up with anther extension point (org.eclipse.ui.decorators), and therefore the definition of EXTENSIONPOINT_UNIQUE_ID at the begining of DecoratorManager should probably read as:

private static String EXTENSIONPOINT_UNIQUE_ID = PlatformUI.PLUGIN_EXTENSION_NAME_SPACE
			+ "." + IWorkbenchRegistryConstants.PL_DECORATORS;

The impact of current implementation would return null from getExtensionPointFilter() which is used in DecoratorManager constructor to create an extension point filter, with a Null value IExtensionPoint applied to ExtensionTracker.createExtensionPointFilter, IFilter#matches method would throw a NullPointerException.

ERROR: org.eclipse.equinox.registry code=2 Problems occurred when invoking code from plug-in: "org.eclipse.equinox.registry". java.lang.NullPointerException
java.lang.NullPointerException
	at org.eclipse.core.runtime.dynamichelpers.ExtensionTracker$1.matches(ExtensionTracker.java:253)
	at org.eclipse.core.runtime.dynamichelpers.ExtensionTracker.notify(ExtensionTracker.java:149)
	at org.eclipse.core.runtime.dynamichelpers.ExtensionTracker.doRemove(ExtensionTracker.java:179)
	at org.eclipse.core.runtime.dynamichelpers.ExtensionTracker.registryChanged(ExtensionTracker.java:119)
	at org.eclipse.core.internal.registry.ExtensionRegistry$2.run(ExtensionRegistry.java:891)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.registry.ExtensionRegistry.processChangeEvent(ExtensionRegistry.java:889)
	at org.eclipse.core.runtime.spi.RegistryStrategy.processChangeEvent(RegistryStrategy.java:267)
	at org.eclipse.core.internal.registry.osgi.ExtensionEventDispatcherJob.run(ExtensionEventDispatcherJob.java:50)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)


Reproducible: Always