Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 292918

Summary: GMF Runtime minor version numbers are not quite correct
Product: [Modeling] GMF-Runtime Reporter: Anthony Hunter <ahunter.eclipse>
Component: GeneralAssignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tikhomirov.artem
Version: 2.2.2   
Target Milestone: 2.2.2   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Anthony Hunter CLA 2009-10-21 12:10:40 EDT
We have not made any feature or content changes to the GMF runtime between GMF 2.2 and GMF 2.3, just a number of bug fizes. But we have incremented the minor version in some plug-ins that makes it look like we have.

To make it clear that the GMF Runtime is equivalent in GMF 2.2 and GMF 2.3, I am going to fix the version numbers to be correct, which will affect both GMF 2.2.2 and GMF 2.3

In some cases, we added API to GMF 2.2.1. Even though the API is binary compatible, we should have incremented the minor version number to 1.3.0 according to the versioning guidelines.

This means that the feature version of the GMF Runtime in GMF 2.2.1 will be 1.3.0.
Comment 1 Anthony Hunter CLA 2009-10-21 12:48:51 EDT
Uggh,

We have already shipped GMF 2.2.1 (Galileo SR1), so I meant the feature version of the GMF Runtime in GMF 2.2.2 (SR2) will be 1.3.0.
Comment 2 Artem Tikhomirov CLA 2009-11-01 19:36:17 EST
(In reply to comment #1)

From the description it sounds like those API additions were for the bugfix release only, if I understood that correctly:

> the feature version of the GMF Runtime in GMF 2.2.2 (SR2) will be 1.3.0.

and 

> We have not made any feature or content changes to the GMF runtime 
> between GMF 2.2 and GMF 2.3

So GMF 2.3 goes with 1.2 feature version, while 2.2.2 with 1.3?
Comment 3 Anthony Hunter CLA 2009-11-02 10:20:49 EST
(In reply to comment #2)
> So GMF 2.3 goes with 1.2 feature version, while 2.2.2 with 1.3?

GMF 2.2.2 has runtime 1.3.
GMF 2.3 also has runtime 1.3. 
So Runtime is the same between 2.2.2 and 2.3.
Comment 4 Anthony Hunter CLA 2010-02-11 12:22:25 EST
From Bug 302518

GMF Runtime in Galileo 3.5.2 SR2 is 1.3.0. It was a minor version change to indicate we made API additions in SR2 that clients needed. i.e. clients depending on the new API need to depend on bundle 1.3.0, if they used 1.2.x the API is not there.

Now draw2d.ui.render.awt has newer API since 3.5.2 SR2, so we need to make bundles 1.3.1, since the Runtime for Helios 3.6.0 is 1.3.1. 

According to the rules however, new public API should mean a minor version change to 1.4.0. @since 1.3 is not correct since the API was not in 1.3.0 of the bundle. 

For now, Runtime in 3.6.0 is version 1.3.1.
Comment 5 Anthony Hunter CLA 2010-02-23 16:15:32 EST
(In reply to comment #4)
> From Bug 302518
> 
> GMF Runtime in Galileo 3.5.2 SR2 is 1.3.0. It was a minor version change to
> indicate we made API additions in SR2 that clients needed. i.e. clients
> depending on the new API need to depend on bundle 1.3.0, if they used 1.2.x the
> API is not there.
> 
> Now draw2d.ui.render.awt has newer API since 3.5.2 SR2, so we need to make
> bundles 1.3.1, since the Runtime for Helios 3.6.0 is 1.3.1. 
> 
> According to the rules however, new public API should mean a minor version
> change to 1.4.0. @since 1.3 is not correct since the API was not in 1.3.0 of
> the bundle. 
> 
> For now, Runtime in 3.6.0 is version 1.3.1.

This is not going to work. API Tools says we should be making the bundle version 1.4 to indicate new API.

I originally added a rule filter, but we should not have to use any filters. Especially since Ed raised the mysterious Bug 301843 .

So runtime is going to have to be version 1.4.0 in Helios 2.6.0 just like API Tools is telling us.

I am going to mark this particular Bugzilla resolved for 2.2.2 since it is.
Comment 6 Eclipse Webmaster CLA 2010-07-19 21:56:51 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug