Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 292906

Summary: build.properties problems should be reported one by one
Product: [Eclipse Project] PDE Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Ankur Sharma <ankur_sharma>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, curtis.windatt.public, darin.eclipse
Version: 3.6   
Target Milestone: 3.6 M7   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Patch
none
updated test cases
none
Final Patch none

Description Dani Megert CLA 2009-10-21 11:18:49 EDT 
I20091020-0931.


I had two source folders missing in the build.properties file but only got one problem reported:

"ui/, jar in jar loader/ is missing from source.."

Besides the fact that it should read "are" instead of "is" I would expect two problems being reported, so that I can apply a quick fix on each of them separately.
Comment 1 Curtis Windatt CLA 2009-10-21 11:59:09 EDT 
It shouldn't be hard to report separate problems, but I am not sure how nicely they will show up in the UI.  I don't think it will be helpful if the user sees a problem, runs the quickfix, leaving another problem, and has to run the quickfix again.  I would expect most users to just want to have the source issues fixed in one step.

If we don't separate the problems we'll fix the text.
Comment 2 Dani Megert CLA 2009-10-21 12:39:44 EDT 
> leaving another problem, and has to run the quickfix again.  
Well, in my particular case I can only get rid of one problem because the other source folder contains initial "source" from which we build a JAR file that's then part of the binary bundle. Hence a combined quick fix would do the wrong thing. In JDT we never fix more than one problem at once. To fix several problems of the same kind the user has to do hit Ctrl+Enter to indicate he wants to fix all of them.
Comment 3 Darin Wright CLA 2010-03-08 11:13:07 EST 
Moving to M7.
Comment 4 Ankur Sharma CLA 2010-03-29 14:46:56 EDT 
Created attachment 163312 [details]
Patch
Comment 5 Ankur Sharma CLA 2010-03-29 14:53:04 EDT 
Created attachment 163313 [details]
updated test cases
Comment 6 Ankur Sharma CLA 2010-03-30 15:01:23 EDT 
Created attachment 163440 [details]
Final Patch
Comment 7 Ankur Sharma CLA 2010-03-30 15:02:10 EDT 
Fixed in HEAD
Comment 8 Dani Megert CLA 2010-03-31 04:35:17 EDT 
Verified in N20100330-2000.