Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 292788

Summary: Buttons in Text-like widgets overlap rounded borders
Product: [RT] RAP Reporter: Ralf Sternberg <rsternberg>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.3   
Target Milestone: 1.3 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Screenshot to show the overall problem none

Description Ralf Sternberg CLA 2009-10-20 12:33:10 EDT 
Currently, the buttons in Combo, Spinner, and DateTime overlap the rounded borders in the fancy and business themes. This is because the rounded borders cannot clip their content. I'll attach a screenshot that shows the problem.

Solution: If a border-radius is applied in the theming of Combo, Spinner, or DateTime, the included subwidgets Combo-Button, Spinner-UpButton, etc. must either be transparent or have a border-radius defined on their own.
Comment 1 Ralf Sternberg CLA 2009-10-20 12:36:07 EDT 
Created attachment 149999 [details]
Screenshot to show the overall problem

This screenshot shows an exaggerated version of the issue. It's not that dramatic in the fancy and business design, but still the edge of the buttons overlap the rounded border.
Comment 2 Holger Staudacher CLA 2009-10-22 10:02:57 EDT 
I played a little bit with the border and border radius attributes of the subwidgets but it doesn't worked well. So I decided to cut of the edges of the images. Changes are in CVS HEAD now and I will close this bug. If you think the behavior still exists please feel free to reopen the bug.
Comment 3 Ralf Sternberg CLA 2009-10-23 06:26:57 EDT 
This workaround fixes the problem only for a single widget height. A theme must work with any widget height, since the widget bounds may change, e.g. by setting a smaller / larger font etc. See also bug bug 292768.

I think for a proper solution, we need to set a gradient and an icon separately. Gradients set via CSS are not affected by this bug, as they are rendered using the GfxWidget. See bug 292817.
Comment 4 Ralf Sternberg CLA 2010-03-09 09:52:14 EST 
Closing since the solution suggested in comment 3 is in place.