Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 292691

Summary:

PDE's use of p2 API

Product:

[Eclipse Project] Equinox

Reporter:

Darin Wright <darin.eclipse>

Component:

Assignee:

P2 Inbox <equinox.p2-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

aniefer, curtis.windatt.public, irbull, pascal, susan, thomas

Version:

3.6

Target Milestone:

3.6 M5

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

292905

Bug Blocks:

291092

Attachments:

Description	Flags
Patch to catch up to p2 branch	none
Patch to update PDE core and UI	none
Patch to react to the some changes around IInstallableUnit	none
patch absorbing changes around iinstallableunit	none
patch to PDE UI for UI policy changes	none
once more, with feeling...	none
small change keeping up with ui api review	none
attached an older patch. This is the one.	none
a patch a day keeps the build error away....	none
repository patch	none
Patch to react to the move of IArtifactKey	none
This patch reacts to the move IU in a public package and other details	none
PDE Core, Buid, IU and o.e.ui.ide patch	none
PDE Core and UI Patch	none
PDE/Build patch	none
Patch covering API changes when simplifying IQuery/IQueryResult	none
Patch to accomodate API changes when adding generics to p2	none
Adapt more changes wrt generics in p2 API	none
small patch to PDE	none
Fixes from moving ProvisionException to API package	none
Fixes from Query API Move (Build)	pascal: review+
PDE UI and Core for Query API Move	none
Patch addressing some types being moved around	none
Patch to PDE build for moving Version/VersionRange to API package	none
Patch to PDE core/ui for moving Version/VersionRange to API package	none
PDE build patch for the changes in IRequirement	none

Description Darin Wright

2009-10-19 13:58:24 EDT

As per Pascal's request, here is PDE's use of p2 APIs

The following PDE bundles use p2 APIs:

org.eclipse.pde.build
org.eclipse.pde.build.tests
org.eclipse.pde.core
org.eclipse.pde.ui
org.eclipse.pde.ui.tests

CVS:

dev.eclipse.org:/cvsroot/eclipse,,pde/build/org.eclipse.pde.build
dev.eclipse.org:/cvsroot/eclipse,,pde/build/org.eclipse.pde.build.tests

dev.eclipse.org:/cvsroot/eclipse,,pde/ui/org.eclipse.pde.core
dev.eclipse.org:/cvsroot/eclipse,,pde/ui/org.eclipse.pde.ui
dev.eclipse.org:/cvsroot/eclipse,,pde/ui/org.eclipse.pde.ui.tests

Comment 1 Curtis Windatt

2009-10-21 11:04:07 EDT

We are branching PDE UI (bug 292905) with the name R3_6_p2_api_cleanup

Comment 2 Andrew Niefer

2009-10-23 17:11:58 EDT

Build has branched "R3_6_api_cleanup"

Comment 3 John Arthorne

2009-11-12 14:46:54 EST

Created attachment 152095 [details]
Patch to catch up to p2 branch

Here is a patch to catch up to some recent changes in the p2 engine API.

Comment 4 Curtis Windatt

2009-11-13 13:42:25 EST

Pinging Andrew, I don't have commit rights to build.

Comment 5 Andrew Niefer

2009-11-13 13:52:34 EST

Comment on attachment 152095 [details]
Patch to catch up to p2 branch

This is a subset of the patch from bug 294334, it is not ready to be released.  I think John just got it mixed in with his stuff after using it for some testing.

Comment 6 John Arthorne

2009-11-13 15:42:08 EST

Yep, that's totally the wrong patch. Trying again...

Comment 7 John Arthorne

2009-11-13 15:43:56 EST

Created attachment 152205 [details]
Patch to update PDE core and UI

Comment 8 Pascal Rapicault

2009-11-16 20:08:28 EST

Created attachment 152362 [details]
Patch to react to the some changes around IInstallableUnit

Comment 9 Pascal Rapicault

2009-11-16 23:07:42 EST

Created attachment 152365 [details]
patch absorbing changes around iinstallableunit

Comment 10 Curtis Windatt

2009-11-17 10:52:20 EST

Pascal's patch has been applied to the PDE UI branch.

Comment 11 Susan McCourt

2009-11-18 14:18:09 EST

Created attachment 152504 [details]
patch to PDE UI for UI policy changes

Curtis, here's a small patch to the target management code for changes to the UI policy API.

Comment 12 Curtis Windatt

2009-11-18 14:47:53 EST

Comment on attachment 152504 [details]
patch to PDE UI for UI policy changes

Applied to the branch

Comment 13 Susan McCourt

2009-11-18 19:28:59 EST

Created attachment 152544 [details]
once more, with feeling...

this patch contains the changes made around bug 253203 and bug 295380.

Comment 14 Curtis Windatt

2009-11-19 11:15:03 EST

Comment on attachment 152544 [details]
once more, with feeling...

Done

Comment 15 Susan McCourt

2009-11-24 12:47:13 EST

Created attachment 152984 [details]
small change keeping up with ui api review

Comment 16 Susan McCourt

2009-11-24 12:54:59 EST

Created attachment 152986 [details]
attached an older patch.  This is the one.

Comment 17 Curtis Windatt

2009-11-24 13:29:47 EST

Comment on attachment 152986 [details]
attached an older patch.  This is the one.

Applied

Comment 18 Susan McCourt

2009-11-25 19:33:34 EST

Created attachment 153141 [details]
a patch a day keeps the build error away....

api change associated with bug 282176

Comment 19 Andrew Niefer

2009-11-27 16:35:47 EST

Created attachment 153282 [details]
repository patch

Patch to keep up with bug 293340

Comment 20 Curtis Windatt

2009-11-27 17:29:37 EST

Applied Andrew's patch.  Haven't tagged though as CVS is still reasonably slow.

Comment 21 Pascal Rapicault

2009-11-30 10:28:29 EST

Created attachment 153349 [details]
Patch to react to the move of IArtifactKey

Comment 22 Curtis Windatt

2009-12-02 13:01:33 EST

Comment on attachment 153349 [details]
Patch to react to the move of IArtifactKey

Applied patch, updated manifest to catch up to repository version increment.  Tagged the PDE UI plug-ins.

Comment 23 Pascal Rapicault

2009-12-06 23:37:57 EST

Created attachment 153895 [details]
This patch reacts to the move IU in a public package and other details

Comment 24 Ian Bull

2009-12-08 02:10:16 EST

Created attachment 153988 [details]
PDE Core, Buid, IU and o.e.ui.ide patch

This patch includes both Simon's work (Profile / Engine) and my work (Collectors / Query).  I'm not sure if ui.ide patches go here or not.

Comment 25 Curtis Windatt

2009-12-08 10:45:07 EST

Applied PDE Core/UI portion of the patch.  Need Andrew to commit the Build portion.  The IDE patch needs to be filed in another bug, I don't think anyone cc'd here has commit rights there.

Comment 26 Susan McCourt

2009-12-08 12:55:43 EST

(In reply to comment #25)
> Applied PDE Core/UI portion of the patch.  Need Andrew to commit the Build
> portion.  The IDE patch needs to be filed in another bug, I don't think anyone
> cc'd here has commit rights there.

I committed the latest ui.ide patch and opened bug 297242 for future ide patches.

Comment 27 Ian Bull

2009-12-16 02:04:20 EST

Created attachment 154541 [details]
PDE Core and UI Patch

This patch is for PDE Core and PDE/UI for the latest query changes.

Comment 28 Ian Bull

2009-12-16 02:04:57 EST

Created attachment 154542 [details]
PDE/Build patch

This patch is for PDE/Build (actually PDE/Build tests) for the latest changes to the query API.

Comment 29 Curtis Windatt

2009-12-16 10:58:26 EST

Comment on attachment 154541 [details]
PDE Core and UI Patch

Applied core/UI patch to the branch.  It's releasing now.

Comment 30 Thomas Hallgren

2009-12-21 11:45:22 EST

Created attachment 154883 [details]
Patch covering API changes when simplifying IQuery/IQueryResult

This patch includes the changes needed after the API changes in bug 298023

Comment 31 Pascal Rapicault

2009-12-21 12:45:40 EST

I have released the PDE build changes from Thomas.

Comment 32 Thomas Hallgren

2009-12-21 16:10:08 EST

Please note that my patch contained some changes for pde.core and pde.ui too. They are not committed yet.

Comment 33 Thomas Hallgren

2009-12-29 20:08:29 EST

Created attachment 155120 [details]
Patch to accomodate API changes when adding generics to p2

Some p2 API methods changed from returning arrays to returning Collections.

Comment 34 Pascal Rapicault

2009-12-31 09:00:04 EST

Created attachment 155154 [details]
Adapt more changes wrt generics in p2 API

Comment 35 Curtis Windatt

2010-01-04 14:26:43 EST

Applied Pascal's latest patch.

Comment 36 Susan McCourt

2010-01-06 19:43:36 EST

Created attachment 155466 [details]
small patch to PDE

Here is a small patch that removes the reference to the now deleted bundle, p2.common.  (See bug 298993).

Comment 37 Curtis Windatt

2010-01-07 11:58:48 EST

Comment on attachment 155466 [details]
small patch to PDE

Applied the patch

Comment 38 John Arthorne

2010-01-07 15:45:46 EST

Created attachment 155547 [details]
Fixes from moving ProvisionException to API package

Comment 39 Ian Bull

2010-01-11 19:54:42 EST

Created attachment 155813 [details]
Fixes from Query API Move (Build)

This patch is for PDE/Build for the query API move.

Comment 40 Ian Bull

2010-01-11 19:56:31 EST

Created attachment 155814 [details]
PDE UI and Core for Query API Move

This patch is for PDE/UI and Core for the query API Move

Comment 41 Pascal Rapicault

2010-01-11 20:36:45 EST

Comment on attachment 155813 [details]
Fixes from Query API Move (Build)

PDE build patch applied

Comment 42 Curtis Windatt

2010-01-12 10:32:00 EST

Comment on attachment 155814 [details]
PDE UI and Core for Query API Move

Applied PDE Core/UI patch.

I assume that PDE Build has been updated with the single change in John's latest patch?  (It just updates a manifest)

Comment 43 Pascal Rapicault

2010-01-12 11:22:38 EST

Created attachment 155879 [details]
Patch addressing some types being moved around

Comment 44 Curtis Windatt

2010-01-12 12:34:51 EST

Comment on attachment 155879 [details]
Patch addressing some types being moved around

Applied latest.

Comment 45 John Arthorne

2010-01-12 15:29:06 EST

Created attachment 155912 [details]
Patch to PDE build for moving Version/VersionRange to API package

Comment 46 John Arthorne

2010-01-12 15:30:19 EST

Created attachment 155913 [details]
Patch to PDE core/ui for moving Version/VersionRange to API package

Comment 47 Curtis Windatt

2010-01-12 16:26:00 EST

Comment on attachment 155913 [details]
Patch to PDE core/ui for moving Version/VersionRange to API package

Applied Core/UI patch

Comment 48 Thomas Hallgren

2010-01-13 10:00:48 EST

Created attachment 155979 [details]
PDE build patch for the changes in IRequirement

Comment 49 Andrew Niefer

2010-01-13 11:18:07 EST

Comment on attachment 155979 [details]
PDE build patch for the changes in IRequirement

Pascal released this

Comment 50 Curtis Windatt

2010-01-18 17:43:10 EST

The merge completed successfully.  Marking as FIXED.