Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 292491

Summary:

org.eclipse.jdt.internal.corext.codemanipulation.AddGetterSetterOperation method[generateSetterMethod] has a miss

Product:

[Eclipse Project] JDT

Reporter:

Liu Yinghui <liu-yinghui>

Component:

Assignee:

JDT-UI-Inbox <jdt-ui-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, liu-yinghui

Version:

3.5.1

Target Milestone:

3.6 M3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
source code	none

Description Liu Yinghui

2009-10-15 22:30:18 EDT

User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; OfficeLiveConnector.1.4; OfficeLivePatch.1.3)
Build Identifier: 20090920-1017

When studing AddGetterSetterOperation、a problem happened.
Method - generateGetterMethod
 if (existing == null || !querySkipExistingMethods(existing))
Method - generateSetterMethod
 if (existing == null || querySkipExistingMethods(existing))

in the method generateSetterMethod, I thingk have to add a "!".

Reproducible: Always

Steps to Reproduce:
1.confirm the AddGetterSetterOperation's source

Comment 1 Liu Yinghui

2009-10-15 22:32:40 EDT

Created attachment 149709 [details]
source code

Comment 2 Frederic Fusier

2009-10-16 03:19:02 EDT

Move to JDT/UI

Comment 3 Dani Megert

2009-10-16 04:32:54 EDT

Good catch!

Fixed in HEAD.
Available in builds > N20091015-2000.

Comment 4 Liu Yinghui

2009-10-16 05:15:05 EDT

Thanks