Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 292467

Summary:	[breakpoints] Redundant call to updateBreakpointStatus() in BreakpointsMediator.stopTrackingBreakpoints()
Product:	[Tools] CDT	Reporter:	Ling Wang <ling.5.wang>
Component:	cdt-debug-dsf	Assignee:	Project Inbox <cdt-debug-dsf-inbox>
Status:	RESOLVED DUPLICATE	QA Contact:	Pawel Piech <pawel.1.piech>
Severity:	normal
Priority:	P3	CC:	pawel.1.piech
Version:	0 DD 1.1
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Ling Wang

2009-10-15 17:08:16 EDT

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6
Build Identifier: 

In BreakpointsMediator.stopTrackingBreakpoints(), it makes call to attributeTranslator.updateBreakpointStatus() when uninstallBreakpoint() finishes. But uninstallBreakpoint() has already done that.
The extra call would cause problem. For instance, our attributeTranslator.updateBreakpointStatus() decrements install-count on the breakpoint. The extra update would screw up the install-count.

Reproducible: Always

Comment 1 Ling Wang

2009-10-15 17:10:39 EDT

The fix is simple, IMHO. Just replace the "new RequestMonitor()" argument in the call to uninstallBreakpoint() with the "countingRM".

Comment 2 Pawel Piech

2009-10-15 17:18:54 EDT

Just out of curiosity, how do you know when to increment and when to decrement the install count in the updateBreakpointStatus() implementation?

Comment 3 Ling Wang

2009-10-15 17:48:10 EDT

(In reply to comment #2)
> Just out of curiosity, how do you know when to increment and when to decrement
> the install count in the updateBreakpointStatus() implementation?

Please see bug 292468.

Comment 4 Pawel Piech

2010-01-08 13:51:24 EST

I believe this is now taken care of.

*** This bug has been marked as a duplicate of bug 292468 ***