Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 292184

Summary:

new command "wrapped line end"

Product:

z_Archived

Reporter:

thomas menzel <tmenzel>

Component:

Mylyn

Assignee:

David Green <greensopinion>

Status:

RESOLVED WONTFIX

QA Contact:

Severity:

enhancement

Priority:

CC:

daniel_megert, pwebster

Version:

unspecified

Keywords:

helpwanted

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
mylyn/context/zip	none

Description thomas menzel

2009-10-13 14:45:15 EDT

i file this bug in request to my posting @ mylyn forum

http://www.eclipse.org/forums/index.php?t=msg&S=1f32f50cd8250b124239ca8b9776e623&th=155712&goto=490589#msg_490589

quoting the content there will be sufficient to describe this enhancement and gives a use case as well:

-----------------------------------------
hi folks,

i love the wiki editor, thx for that but this is what drive me nuts lately, and i bet there must be setting for this but i cant seem to find it.

1. long lines are wrapped automatically, good
2. hitting the end key; command: editing text/line end will bring it to the char before the line feed and not the end of the current line as usual.

this is very bothersome when you edit longer paragraphs!!!

plz safe my life and tell me the setting or add it ASAP.

-----------------------------------------
reply:

Thomas,

As you observed the end key (or Command-Right Arrow on a Mac) corresponds to the 'Line End' command. This command takes
you to the end of the line as you observed. The line end is determined by the position of the EOL character(s) in the
document. The line-wrap that you're observing in the editor depends on the size of the viewable area in the editor, and
does not correspond to the end of line. I believe that this is how all text editors in Eclipse behave. If you feel
that this is a bug, feel free to file a bug against Eclipse UI. Otherwise feel free to create an enhancement request
for a command that will position the caret at the end of the line as displayed in the source viewer considering line-wrap.

Regards,

David

Comment 1 thomas menzel

2009-10-13 14:56:15 EDT

IMO instead of creating a new command i think it shouldn't be too problematic
to actually change the behavior of the 'line end' (which by default is bound to
the END key on windows) to jump to end of the line where it wraps visibly to
the next line, whether there be an EOL or not. 

this is how most editors work on windows (cant think of any that go to EOL) and
i guess the expected behavior.

i guess this enhancement hasnt been requested before since eclipse is an IDE
and a line here is relativly short and there is little using of the autowrap
feature (cant even find that setting to turn that on in normal editors...).

cheers

Comment 2 David Green

2009-10-16 12:10:12 EDT

Thanks for the feature request!

(In reply to comment #1)
> IMO instead of creating a new command i think it shouldn't be too problematic
> to actually change the behavior of the 'line end' (which by default is bound to
> the END key on windows) to jump to end of the line where it wraps visibly to
> the next line, whether there be an EOL or not.

I agree that it wouldn't be hard, however I am reluctant to change default platform behaviour in this case, since others may be using this function and expect it to behave consistently with other Eclipse editors.
That said, Eclipse is wonderfully configurable, so a new command could easily have the same keybindings as the existing command if you choose to set it up in your workspace preferences.

Please feel free to make a contribution in the form of a patch that adds a new command.

Comment 3 thomas menzel

2009-10-16 12:26:13 EDT

maybe such a platform wide change (new command or chnaging the current impl) should be discussed with the SWT people? or rather move this bug to their inbox?

what do u think?

Comment 4 David Green

2009-10-19 11:19:25 EDT

(In reply to comment #3)
> or rather move this bug to their inbox?

Yes, it seems to me that this feature is more platform-related than WikiText.
For your reference, the 'Line End' command is implemented by org.eclipse.ui.texteditor.AbstractTextEditor.LineEndAction

Moving to Platform UI.

Comment 5 David Green

2009-10-19 11:20:30 EDT

Created attachment 149884 [details]
mylyn/context/zip

Comment 6 Dani Megert

2009-10-19 11:45:09 EDT

There's currently no word wrap support for textual editors and hence we won't change the line end action. Since Mylyn introduces word wrap it also has to handle this particular request.

Comment 7 thomas menzel

2009-10-23 08:00:30 EDT

(In reply to comment #6)
> There's currently no word wrap support for textual editors and hence we won't
> change the line end action. Since Mylyn introduces word wrap it also has to
> handle this particular request.

sorry to barge in on this, but shall i understand this comment such,that Mylyn should only do this in its own realm, i.e. in the wiki text bundle? 

IMO, line wrapping is a platform thing - if not SWT  (or should be ) - and hence should provide the support for this b/c i bet there might be other consumers of such a feature.

if this comment is only in regard who shall impl. this, i have nothing to say about this, except should this issue then be really in the Mylyn project?

Comment 8 Dani Megert

2009-10-23 08:25:41 EDT

> i understand this comment such,that Mylyn
>should only do this in its own realm, i.e. in the wiki text bundle? 
Well understood. Since the wiki editor decided to run ahead of what exists in the Platform it also has to deal with such requests.

Comment 9 David Green

2013-08-02 12:42:58 EDT

Closed as part of backlog clean-up.  Please re-open if you'd like to see this revisited, perhaps with a contribution.