Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 290739

Summary: [hotbug] Don't validate the expression segments after the map if the map value type is Object
Product: [WebTools] Java Server Faces Reporter: David Williams <david_williams>
Component: JSF ToolsAssignee: Cameron Bateman <cameron.bateman>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: david_williams, edwinc, raghunathan.srinivasan, robert_gallagher, xiaonan_jiang
Version: unspecified   
Target Milestone: 3.0.5 P   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 288831    
Bug Blocks:    

Description David Williams CLA 2009-09-28 15:14:34 EDT
+++ This bug was initially created as a clone of Bug #288831 +++

This is purely a tracking bug, to track the request and work of putting this in a 305 patches stream.
Comment 1 David Williams CLA 2009-09-28 15:15:57 EDT
Requesting this bug be given high priority, as it has large negative impact on some IBM adopter products. 

I'll give exact directions about patch stream shortly.
Comment 2 David Williams CLA 2009-09-28 16:10:04 EDT
We've used a "test patch" to confirm this fix works as expected. 


General procedure for creating patch feature.

To create patches, our latest general documentation is at 
http://wiki.eclipse.org/WTP/Build/WTP_Patches_for_Release_2.0.2 
and may be "dated" in some of the specifics, but the concepts are
the same. But here's the specifics for these 4 JSF bugs requested
for 3.0.5 patches: 

The patches involve 2 bundles, and the starting point is 
of course what was released in WTP 3.0.5, which can 
be found by looking in the map files for that release. 

First, load these bundles with these tag names into workspace: 

org.eclipse.jst.jsf.common  v20090128
org.eclipse.jst.jsf.core    v20090508

From those, use "Team, Branch ..." to create a branch named 
R3_0_5_patches

Apply the patches, and commit (to that branch) with appropriate 
cvs comments to reflect the bugs fixed. 

Once all have been committed, then use "Team, Tag as Version ..."
to tag those revisions with something like the usual tag name, 
such as v200909281200

Then let us know what tagged you used (for each bundle, if not 
exactly the same). 

Carl or I will do the rest. The feature these bundles were in 
was org.eclipse.jst.web_core.feature so they will go into 
a patch feature named org.eclipse.jst.web_core.feature.patch, 
which already exists in the R3_0_5_patches stream. 

Similarly, Carl or I can "manually" update the map files in 
releng.jsf which have already been branched to R3_0_5_patches. 
And, finally, we will do the actual build and make it available
in the usual place: http://download.eclipse.org/webtools/patches/


Be sure to merge or re-apply the fixes to 3.1.2 and Helios steams.
Comment 3 Raghunathan Srinivasan CLA 2009-10-05 01:30:07 EDT
Testing in progress based on comments in 288831
Comment 4 Raghunathan Srinivasan CLA 2009-10-21 15:09:15 EDT
All tests pass with the latest patch (3). Patch released.
Comment 5 Raghunathan Srinivasan CLA 2009-10-21 15:15:20 EDT
Tagged as v200910211246
Comment 6 David Williams CLA 2009-10-21 16:10:26 EDT
Thanks Xiaonan and Raghu. I've updated map file and patch features to include in patch builds after 10/22.
Comment 7 Xiaonan Jiang CLA 2010-06-23 15:38:40 EDT
Verified it worked. David, please help to close the bugzilla.