Bug 290430

Description Johannes Gebauer 2009-09-24 11:39:36 EDT

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier: I20090611-1540

If a Pull Up Method Refactoring moves a method into a superclass that has other subclasses referenceing a related method that was declared in a superclass of the destination type, they reference the pulled up method after the refactoring. This problem can be caused by simple method calls that reference the method in a superclass or overriding methods using a super call.

The refactoring processor does not analyze the influence of overriding in other sublcasses. I think it should at least warn of changes in the behaviour.

Reproducible: Always

Steps to Reproduce:
1. 
Create the following classes:

public class SuperDestination {
	public void m() {
		System.out.println("super destination behaviour");
	}
}

public class Destination extends SuperDestination {
}

public class Referencer extends Destination {
	public void n() {
		m();
	}
}

public class SuperReferencer extends Destination {
	public void m() {
		super.m();
	}
}

public class DeclaringType extends Destination {
	public void m() {
		System.out.println("declaring type behaviour");
	}
}

2.
Now perform a pull up refactoring to move the method "DeclaringType.m()" to the class "Destination".

3.
The refactoring performs without giving a warning/error. This is not desirable because the behaviour of the refactored program changed in two points:

(a)
Before the refactoring the method body of "Referencer.n()" referenced the method "SuperDestination.m()".
After the refactoring it references the pulled up method "DeclaringType.m()" that causes a changed behaviour.

(b)
Before the refactoring the method body of "SuperReferencer.n()" referenced the method "SuperDestination.m()".
After the refactoring it references the pulled up method "DeclaringType.m()" that causes a changed behaviour.