Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 290278

Summary:	[Net] username, password of manual Proxy is not persisted.
Product:	[Eclipse Project] Platform	Reporter:	Oleg Besedin <ob1.eclipse>
Component:	Team	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	henrich.kraemer, kazm, ob1.eclipse, pawel.pogorzelski1, slewis, Szymon.Brandys, tjwatson, wojciech.galanciak
Version:	3.6
Target Milestone:	3.8 M4
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Oleg Besedin

2009-09-23 11:02:50 EDT

+++ This bug was initially created as a clone of Bug #286354 +++

Created an attachment (id=144180)
Except of .log file showing the logged entry mentioned in description

Build ID: M20090807-0800

Steps To Reproduce:
This may only happen on windows and also requires bad content in secure_storage
preferences file.
1. Goto preferences page 'Network Connections' and select Manual for Active
Provider. Select HTTP and Edit an then provide proxy information as well as
credentials and OK. Notice that the table reflects the entered credentials.
2. Say OK which should apply the preference page.
3. Bring up the preference page again.
The credentials have not been persisted. There is no user feedback such as an
error message that there was a problem. However the error log does have an
entry which seemed somewhat misleading to me.

Will attach more information about observed stack traces shortly.

Comment 1 Oleg Besedin

2009-09-23 11:17:28 EDT

I'd suggest adding an extra error dialog to the ProxyType.saveProxyAuth(). 

At present it catches StorageException and logs it. I would suggest to add an extra error message along the lines of "Unable to save the proxy authorization information. You can use Secure Storage preferences page to delete corrupted data (see "Contents" tab)." 

Depending on how sophisticated you'd like to make it, it could be just an extra text written in the error log, or a message dialog, or even a message dialog with the link to open the Secure Storage preference page.

Comment 2 Pawel Pogorzelski

2010-04-26 07:00:19 EDT

Moving to 3.7.

Comment 3 Krzysztof Kazmierczyk

2010-08-16 04:40:55 EDT

Oleg, I was not able to reproduce this bug. Does it require any specific corruption of secure storage?

From another hand there might be also several other reproduction steps when similar log error appears and there is no dialog. My example tested scenario:
1. Set proxy username/password in Eclipse
2. Close Eclipse
3. Modify following (or similar) line in your secure_storage:
/org.eclipse.core.net.proxy.auth/HTTP/user=org.eclipse.equinox.security.windowspasswordprovider\tFtPtqIglboo\=,mFONfYtLvsQ\=
to this one 
/org.eclipse.core.net.proxy.auth/HTTP/user=org.eclipse.equinox.security.windowspasswordprovider\twC
4. Start Eclipse.

Another example is deleting security_storage file between Eclipse sessions. In such case you don't have even any error message in the log despite the fact proxy preferences have been changed.

Szymon do we want to fix in net.ui kinds of bugs related to broken/incomplete security storage?

Comment 4 Malgorzata Janczarska

2011-11-18 04:57:49 EST

Oleg, I was also unable to reproduce this problem. Do you know what should I do with my secure storage to reproduce it?
(In reply to comment #1)
> At present it catches StorageException and logs it.
Can you attach this log?

Comment 5 Oleg Besedin

2011-11-23 11:10:52 EST

(In reply to comment #4)
> Oleg, I was also unable to reproduce this problem. 

I cannot reproduce using N20111114-2115.

Comment 6 Malgorzata Janczarska

2011-11-23 11:33:13 EST

(In reply to comment #5)
> (In reply to comment #4)
> > Oleg, I was also unable to reproduce this problem. 
> 
> I cannot reproduce using N20111114-2115.

Marking as WORKSFORME, because probably it's to be no longer reproduceable.