Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 289968

Summary:

Thumbnail-ThumbnailUpdater No of tiles calculation should be done according to the source figure size

Product:

[Tools] GEF

Reporter:

Vijay Raj <vijay.rajonline>

Component:

GEF-Legacy Draw2d

Assignee:

Alexander Nyßen <nyssen>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

bokowski, nyssen, vijay.rajonline, vijay_g

Version:

3.4

Target Milestone:

4.0.0 / 3.11.0 (Neon) M2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed patch based on my patch for 330856	none

Description Vijay Raj

2009-09-21 03:32:17 EDT

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier:  M20090211-1700

The Thumbnail updater MAX_BUFFER_SIZE variable should be calculated on runtime according to the source figure size...
The current value of MAX_BUFFER_SIZE = 256 is to low in case of large source figure..
Because of small size of buffer the no of tiles to be updated is large hence for a large figure the thumbnail is generated slowly...
slower then the source figure generation!


Reproducible: Always

Comment 1 Vijay Raj

2010-09-17 01:20:02 EDT

Any progress on this???

Comment 2 Wayne

2010-11-22 16:14:38 EST

Created attachment 183605 [details]
Proposed patch based on my patch for 330856

Comment 3 Alexander Nyßen

2011-10-17 14:49:18 EDT

Comment on attachment 183605 [details]
Proposed patch based on my patch for 330856

The patch seems to be a bit overcomplicated. If I do not miss anything, its only effect is  to limit the number of tiles to be at most 16. Why does it still rely on the MAX_BUFFER_SIZE in this case?

Comment 4 Alexander Nyßen

2015-09-17 16:14:08 EDT

Implemented that at most 16 tiles exist, having a min size of 256. Pushed changes to origin/master. Resolving as fixed in 3.11.0 M2.