Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 289722

Summary: [Theming] Make background image of welcome page themable
Product: [RT] RAP Reporter: Rüdiger Herrmann <ruediger.herrmann>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: b.muskalla
Version: 1.0   
Target Milestone: 1.3 M2   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 289343    

Description Rüdiger Herrmann CLA 2009-09-17 07:31:24 EDT 
The background image that is currently hard-coded in the index.html should be themable.
Suggested syntax:
  Display {
    background-image: myimage.gif
  }
Comment 1 Rüdiger Herrmann CLA 2009-09-18 06:12:30 EDT 
*** Bug 243066 has been marked as a duplicate of this bug. ***
Comment 2 Rüdiger Herrmann CLA 2009-09-24 15:55:52 EDT 
Now there is a property background-image for the CSS element Display that controls which image is shown on the browser windows' client area.
Changes are in CVS HEAD
Comment 3 Ivan Furnadjiev CLA 2009-09-25 03:21:41 EDT 
Running the controls demo with alternate theme ("tea" servlet) leads to exception:
2009-09-25 10:23:08.583::WARN:  ERROR:  /tea
org.eclipse.rwt.internal.util.Assert$AssertionFailedException: No resource registered for key resource/widget/rap/display/bg.gif
	at org.eclipse.rwt.internal.util.Assert.isNotNull(Assert.java:31)
	at org.eclipse.rwt.internal.resources.ResourceManagerImpl.getLocation(ResourceManagerImpl.java:283)
	at org.eclipse.rap.ui.internal.servlet.ResourceManagerFactory$ResourceManagerWrapper.getLocation(ResourceManagerFactory.java:105)
	at org.eclipse.rwt.internal.service.BrowserSurvey.getBgImage(BrowserSurvey.java:77)
	at org.eclipse.rwt.internal.service.BrowserSurvey.renderScript(BrowserSurvey.java:107)
	at org.eclipse.rwt.internal.service.BrowserSurvey.sendBrowserSurvey(BrowserSurvey.java:52)
	at org.eclipse.rwt.internal.service.LifeCycleServiceHandler.internalService(LifeCycleServiceHandler.java:197)
	at org.eclipse.rwt.internal.service.LifeCycleServiceHandler.access$1(LifeCycleServiceHandler.java:185)
	at org.eclipse.rwt.internal.service.LifeCycleServiceHandler$LifeCycleServiceHandlerSync.doService(LifeCycleServiceHandler.java:150)
	at org.eclipse.rwt.internal.lifecycle.RWTLifeCycleServiceHandlerSync.serviceInternal(RWTLifeCycleServiceHandlerSync.java:48)
	at org.eclipse.rwt.internal.lifecycle.RWTLifeCycleServiceHandlerSync.service(RWTLifeCycleServiceHandlerSync.java:36)
	at org.eclipse.rwt.internal.service.LifeCycleServiceHandler.service(LifeCycleServiceHandler.java:157)
	at org.eclipse.rwt.internal.service.ServiceManager$HandlerDispatcher.service(ServiceManager.java:101)
	at org.eclipse.rwt.internal.engine.RWTDelegate.doPost(RWTDelegate.java:60)
	at org.eclipse.rap.ui.internal.servlet.RequestHandler.service(RequestHandler.java:51)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
	at org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
	at org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:111)
	at org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:59)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
	at org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManager.java:318)
	at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:502)
	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:380)
	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
	at org.mortbay.jetty.Server.handle(Server.java:324)
	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:535)
	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:865)
	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:540)
	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:213)
	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
	at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:520)
Comment 4 Benjamin Muskalla CLA 2009-09-25 04:30:53 EDT 
We should also mention how the image itself needs to be scaled in the absence of an alignment/repeat property.
Could be part of the description in the theme.xml file.
Comment 5 Rüdiger Herrmann CLA 2009-09-25 09:35:33 EDT 
The problem as described in comment #3 is now fixed.