Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 289556

Summary:	'Restore Defaults' on 'Compare/Patch' flickers
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	Compare	Assignee:	Pawel Pogorzelski <pawel.pogorzelski1>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	pawel.pogorzelski1
Version:	3.0
Target Milestone:	3.6 M3
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	289599
Bug Blocks:

Description Dani Megert

2009-09-16 03:45:46 EDT

Since R3.0.

Steps to reproduce:
1. start fresh workspace
2. Window > Preferences > General > Compare/Patch
3. click 'Restore Defaults' several times
   ==> flickering as this seems to trigger/click the 'OK' button

Same issue when on the 'Text Compare' tab. No problems for other preference pages.

Comment 1 Pawel Pogorzelski

2009-09-16 07:16:32 EDT

Dani, I can't see any flickering on last I-build. I've just checked the code and performDefaults() only sets default values in widgets. Nothing more.

Comment 2 Dani Megert

2009-09-16 07:52:27 EDT

Carefully look at the 'OK' button when clicking the 'Restore Defaults' button quickly several times.

I can easily see this on I20090916-0100.

Comment 3 Pawel Pogorzelski

2009-09-16 09:11:26 EDT

Got it, only the "OK" button flickers. I thought you meant the whole page does. 

It's caused by bug 289599, I've attached a patch on it. Lets wait for JDT guys to review the code.

Comment 4 Pawel Pogorzelski

2009-09-16 09:40:12 EDT

(In reply to comment #3)
> Lets wait for JDT guys to review the code.

I meant JFace.

Comment 5 Dani Megert

2009-09-16 10:06:04 EDT

All other pages don't have this behavior, so there must be something special on the Compare page.

Comment 6 Pawel Pogorzelski

2009-09-30 14:56:14 EDT

Bug 289599 has been fixed in HEAD. I works in self hosted Eclipse with JFace from HEAD. Marking as FIXED.