Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 289346

Summary:

[Widgets] Gtk SWT should set type hint for floating shell windows

Product:

[Eclipse Project] Platform

Reporter:

Danny Baumann <dannybaumann>

Component:

SWT

Assignee:

Eric Williams <ericwill>

Status:

VERIFIED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

ericwill, pinnamur, remy.suen, xixiyan

Version:

3.5

Keywords:

triaged

Target Milestone:

4.9 M2

Hardware:

OS:

Linux

See Also:

https://git.eclipse.org/r/125541
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3b6cbf693da065f49bef820d886990d8397f3ebc

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none

Description Danny Baumann

2009-09-14 09:02:58 EDT

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.3) Gecko/20090909 Fedora/3.5.3-1.fc11 Firefox/3.5.3
Build Identifier: I20090611-1540

SWT shell windows can be given the TOOL style, which means (according to the documentation) "A tool window is a window intended to be used as a floating toolbar. It typically has a title bar that is shorter than a normal title bar.".

Those windows should be given an appropriate hint to distinguish them from non-floating shell windows. The EWMH (http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#id2507144) seems to suggest _NET_WM_WINDOW_TYPE_UTILITY is the best fit here. _NET_WM_WINDOW_TYPE_TOOLBAR would fit the description as well, but the TOOL SWT hint is also used for other window types (e.g. for source information tooltips).

I will attach a (trivial) patch that adds that code.

Reproducible: Always

Comment 1 Danny Baumann

2009-09-14 09:03:54 EDT

Created attachment 147096 [details]
Proposed fix

Patch that sets the TOOLTIP window type hint for SWT TOOL windows.

Comment 2 Eric Williams

2016-10-09 11:30:50 EDT

If there are no objections to this addition I'll take a look at it and merge.

Comment 3 Eclipse Genie

2018-07-04 11:01:29 EDT

New Gerrit change created: https://git.eclipse.org/r/125541

Comment 4 Eclipse Genie

2018-07-04 11:45:50 EDT

Gerrit change https://git.eclipse.org/r/125541 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3b6cbf693da065f49bef820d886990d8397f3ebc

Comment 5 Eric Williams

2018-07-04 11:46:10 EDT

(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/125541 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=3b6cbf693da065f49bef820d886990d8397f3ebc

Patch is in master now.