Bugzilla – Full Text Bug Listing
| Summary: | JUnit tests assuming precision of 19 and higher for "DOUBLE PRECIS" and "NUMERIC" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Dies Koper <dieskun> | ||||
| Component: | Eclipselink | Assignee: | Project Inbox <eclipselink.orm-inbox> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | tom.ware | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
I found a few more of type NUMBER: - If you search the test code for ".setSize(38)", you'll find all three. Created attachment 147001 [details]
Patch for bugs 289019-289023
Checked in fix for bug 289019, bug 289020, bug 289021 and bug 289023 These fixes are changes suggested by the bug filer and are reasonably simple. I have reviewed the changes as they were added and run the existing tests to ensure they do not break anything. The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink |
Some JUnit tests use fields of type "DOUBLE PRECIS" or "NUMERIC" with precision 32. Symfoware maps these to "NUMERIC" but does not take a precision higher than 18. If not important to the purpose of the test, reducing the precision to 18 or lower would allow us to include these tests in (regression) testing for the Symfoware platform. I will not attach a patch as you would be in a better position to make the call whether occurrences of these precisions can be reduced or not. - If you search the test code for "DOUBLE PRECIS" you'll find it followed by either field.setSize(15) or field.setSize(32). The latter causes this issue. - If you search the test code for ".setSize(19)" and you find it following "setTypeName("NUMERIC");", it is causing this issue. Thanks!