Bugzilla – Full Text Bug Listing
| Summary: | [upstream] changing timezones results in mid-air collisions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Robert Elves <robert.elves> | ||||||
| Component: | Mylyn | Assignee: | Frank Becker <eclipse> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Robert Elves <robert.elves> | ||||||
| Severity: | normal | ||||||||
| Priority: | P1 | CC: | jacek.pospychala, webmaster | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 3.4 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| URL: | https://bugzilla.mozilla.org/show_bug.cgi?id=515515 | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 261868 | ||||||||
| Attachments: |
|
||||||||
|
Description
Robert Elves
In bugzilla's user preferences changing General Preferences > "Timezone used to display dates and times" to something other than Site Default will result in subsequent submission of changes from the task editor to fail with a mid-air collision. Posted bug against bugzilla.mozilla.org: 515515: mid-air collision results when user's timezone preference differs from server's https://bugzilla.mozilla.org/show_bug.cgi?id=515515 Rob, is this getting fixed in Bugzilla? A working patch was submitted but Max is considering implementing my original suggestion (which would be best if they can do it). I'll ping them again to see what the plan is. I guess my question really is if we are ready to make the necessary changes in Mylyn in time for 3.2.2 (Feb 24th) so that this magically starts working when the fixed Bugzilla release becomes available. We have a potential in a race condition here since it hinges on if we send back the timezone in the date stamp. We currently strip this information in order to avoid mid-air collisions since the server doesn't accept this date format. The proposed changes to the bugzilla server would in fact require the timezone. We could add a bugzilla version check and only strip the time zone if the repository is < 3.4.x but of course if the fix doesn't make it into bugzilla, or if an alternate solution is taken we'll have a problem. Thanks Rob. Let's see if we there is more uptream progress in the next two weeks otherwise we'll move the bug to 3.4. Timed out. Moving to next release milestone. Frank's patch on 515515 has been accepted (awesome work Frank!). So we can begin to test with the next 3.6 rc or post 3.4.6 release of Bugzilla. We'll need to wrap the current BugzillaClient.striptimezone only execute for repos <= 3.4.6. Created attachment 164085 [details]
commited patch
Created attachment 164086 [details]
mylyn/context/zip
Rob, please verify! Great Frank. Excellent work on this and the Bugzilla patch/backport. |