Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 288992

Summary: Published project modules missing the "Started" status in the Servers view
Product: [WebTools] WTP ServerTools Reporter: Steven Hung <sghung>
Component: wst.serverAssignee: Elson Yuen <eyuen7>
Status: CLOSED FIXED QA Contact: Angel Vera <arvera>
Severity: normal    
Priority: P3 CC: eyuen7
Version: unspecifiedKeywords: plan
Target Milestone: 3.2 M5Flags: arvera: review+
Hardware: PC   
OS: Windows XP   
See Also: https://git.eclipse.org/r/108853
Whiteboard:
Attachments:
Description Flags
v1.0 arvera: iplog+, arvera: review+

Description Steven Hung CLA 2009-09-09 15:56:26 EDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: Eclipse 3.4

When publishing a project, the module does not say "Started" as it did in previous versions.  For example:

Bundled GlassFish v2.1 [Started, Synchronized]
|
-->earProj4 [Synchronized]
     |
     -->earProje4EJB [Synchronized]
     |
     --> earProj4Web [Synchronized]

Should instead be:
Bundled GlassFish v2.1 [Started, Synchronized]
|
-->earProj4 [Started, Synchronized]
     |
     -->earProje4EJB [Synchronized]
     |
     --> earProj4Web [Synchronized]

Reproducible: Always

Steps to Reproduce:
1. Import a project, say a dynamic web project
2. Add the project to the server
3. Check the status after the server synchronizes

Expect: the module should show the status "Started"
Comment 1 Elson Yuen CLA 2009-12-17 09:41:58 EST
Created attachment 154662 [details]
v1.0
Comment 2 Elson Yuen CLA 2009-12-17 09:46:41 EST
The fix is to have the proper implementation on providing the module state on the ServerDecorator.  The patch reuses the state label mechanism as the server state to maximize the reuse of the state label code and make it consistent to the server state display.  When the module state is in unknown state, the state information will not be shown.

Test involved:
The test has been done on a tomcat server (that doesn't provide module state) to make sure the module state does not show.  I then mock up the tomcat server to provide a module state which then displays the module state properly.
Comment 3 Elson Yuen CLA 2009-12-17 09:46:53 EST
Angel, please assign this one to me.
Comment 4 Angel Vera CLA 2010-01-20 12:43:41 EST
Changes committed to HEAD
Comment 5 Angel Vera CLA 2010-01-20 18:03:45 EST
Changes released to HEAD
Comment 6 Eclipse Genie CLA 2017-10-11 16:30:51 EDT
New Gerrit change created: https://git.eclipse.org/r/108853