Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 288961

Summary: Setting the launch with configuration option to 'all' should reset changed start levels
Product: [Eclipse Project] PDE Reporter: Michael Rennie <Michael_Rennie>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, jeffmcaffer
Version: 3.5Keywords: helpwanted
Target Milestone: 3.6 RC1   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Michael Rennie CLA 2009-09-09 13:29:42 EDT 
I20090908-0800

When editing a PDE launch configuration setting the launch with option from "plugins selected below" to "all workspace + target plugins" should reset any changed start settings, since you can no longer edit the start levels, etc.

Steps:

1. change the launch with setting of a config to "plugins selected..." and change a known bundle to autostart. Save configuration
2. launch to confirm it autostarts
3. edit the configuration to set the launch with setting back to the "all workspace..." option. Save configuration
4. relaunch and notice the bundle still auto-starts

Expected:
the bundle would no longer auto-start since I cannot change the setting when using the "all workspace..." launch with option.
Comment 1 Curtis Windatt CLA 2009-09-17 10:06:21 EDT 
Investigate in M3
Comment 2 Jeff McAffer CLA 2009-10-20 15:01:42 EDT 
as a point of interest, why is it that you cannot set the start settings when you choose All?  Seems like the requirement to manage starting is separate from the need to choose bundles to be installed.
Comment 3 Curtis Windatt CLA 2009-10-26 12:22:41 EDT 
Didn't get to this in M3.
Comment 4 Curtis Windatt CLA 2010-05-06 15:11:40 EDT 
I couldn't reproduce using the steps you described, the bundles.info always has the default value.  I also stepped through the code to see what could be going wrong.  However, the code seems solid.  When you use selected plug-ins below only, we save a list of checked plug-ins along with their start settings.  When you switch back to 'all enabled', we don't clear the attributes (so when you switch the combo back your settings stay), but we do set another 'use default' attribute.  There is only one method in the launcher where we access those custom start level settings and if the use default attribute is set, we never reach that code (using default:default).

Closing as WORKSFORME since the code appears to be doing the right thing.  Maybe in your case your default auto-start setting had been changed to true or maybe you were messing with the start level of a bundle that we have hard coded values for (ex. we set simple configurator's start level to a specific value if it is default).