Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 288391

Summary: Too many files are checked out when faces-config is modified
Product: [WebTools] Java Server Faces Reporter: Christine Rice <ricec>
Component: CoreAssignee: Ian Trimble <ian.trimble>
Status: CLOSED FIXED QA Contact: Ian Trimble <ian.trimble>
Severity: normal    
Priority: P3 CC: raghunathan.srinivasan, robert_gallagher
Version: unspecifiedKeywords: plan
Target Milestone: 3.2 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard: Extensibility
Attachments:
Description Flags
Proposed patch raghunathan.srinivasan: iplog+

Description Christine Rice CLA 2009-09-02 13:47:53 EDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: Code from HEAD

This was found in an adopter product. 

If a web project is under source control (such as the Eclipse Pessimistic Simple Provider) and the faces-config model is programmatically addressed through artifact edit, everything else that uses the artifact edit model will be checked out. Since only faces-config is being modified, only that should be checked out.

The fix is to add an editModelID and use that id in the constructor of FacesConfigArtifactEdit; this restricts the files being checked out.

A patch is attached. 

Reproducible: Always
Comment 1 Christine Rice CLA 2009-09-02 13:48:43 EDT
Created attachment 146303 [details]
Proposed patch
Comment 2 Ian Trimble CLA 2010-03-26 15:44:44 EDT
Fix checked in at: 03/26/2010 12:41 PM.
Comment 3 Christine Rice CLA 2010-04-21 14:53:10 EDT
Verified in an adopter product.
Comment 4 Christine Rice CLA 2010-04-21 14:53:27 EDT
Closing.