Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 288124

Summary: Refactor the ControlLCAUtil#writeStyleFlags regarding SWT.FLAT
Product: [RT] RAP Reporter: Asen Draganov <asen>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.3   
Target Milestone: 1.3 M5   
Hardware: All   
OS: All   
Whiteboard:

Description Asen Draganov CLA 2009-08-31 10:02:26 EDT 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: 20090619-0625

FLAT should be removed from ControlLCAUtil#writeStyleFlags, because it only needs to be written for several widgets. This would leave this method with one style flag (BORDER) to write, so it should be inlined.

FLAT flag is applicable to the following widgets: Button, ToolBar, CoolBar, CTabFolder, CCombo.


Reproducible: Always
Comment 1 Rüdiger Herrmann CLA 2010-01-26 16:04:32 EST 
Removed the 'writeStyleFlags( "FLAT" )' call from ControlLCAUtil#writeStyleFlags. All mentioned LCA's now individually call WidgetLCAUtil#writeStyleFlags
Changes are in CVS HEAD