Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 286858

Summary:

change director call to use pde build's runDirector task

Product:

[Eclipse Project] Platform

Reporter:

Kim Moir <kim.moir>

Component:

Releng

Assignee:

Kim Moir <kim.moir>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

aniefer, dj.houghton

Version:

3.6

Target Milestone:

3.6 M2

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

247332

Attachments:

Description	Flags
patch to pde build runDirector target	none
patch	none

Description Kim Moir

2009-08-17 15:17:19 EDT

Currently, the director call in the build calls the p2.director by calling by invoking the exe via ant exec and org.eclipse.equinox.p2.director.app.application.  It would be better to call it by invoking the runDirector task in pde build's genericTargets.xml.  This would also allow the task to run on various platform, in support of moving the build to build.eclipse.org. in bug 247332.

org.eclipse.pde.build/scripts/genericTargets.xml runDirector
<ant file="${eclipse.pde.build.scripts}/genericTargets.xml" target="runDirector" />
<ant antfile="${eclipse.pdebuild.scripts}/genericTargets.xml" target="runDirector" inheritAll="true">
			<property name="p2.repo" value="${p2.build.repo}"/>
			<property name="p2.director.iu" value="org.eclipse.mylyn_feature.feature.group"/>
			<property name="p2.director.installPath" value="${eclipse.base}"/>
		</ant>

Comment 1 DJ Houghton

2009-08-17 15:51:43 EDT

Note that at one point we had problems setting the system properties for calls to Ant tasks so we stuck with spawning a new exe call in the script. Not sure if those problems are still around but something to keep in mind... (bug 209185)

Comment 2 Kim Moir

2009-08-18 13:51:35 EDT

Created attachment 144853 [details]
patch to pde build runDirector target

patch to pde build scripts/genericTargets.xml runDirector target so metadataRepositoryName and artifactRepositoryName are included in the director call.  This allow this releng build to use this target directly.

Comment 3 Kim Moir

2009-08-18 13:52:26 EDT

Andrew, see the patch in comment #2 for pde build.  Not sure what the repository name should be in your scripts.

Comment 4 Andrew Niefer

2009-08-18 14:07:40 EDT

Unless I'm missing something, the director application doesn't do anything -metadataRepositoryName and -artifactRepositoryName.

The new "org.eclipse.equinox.p2.director" application would actually throw an "unknown option" exception on those.

Comment 5 Kim Moir

2009-08-18 14:19:30 EDT

Okay, sorry, they were in my scripts.  They must have been used in an older iteration of the director app.  I'll remove them.

Comment 6 Kim Moir

2009-08-18 17:13:39 EDT

I changed the build to call the launcher jar instead of the in bug 247332 comment 9 so this task can run on multiple platforms.   I'm having a lot of problems calling the task in pde build and I think it would be simpler just to leave the director call in my build scripts instead of spending more time troubleshooting this issue.  There are a lot of other bugs to solve :-)

Comment 7 Kim Moir

2009-08-21 09:12:59 EDT

Created attachment 145264 [details]
patch

fixed afterall

Comment 8 Kim Moir

2009-08-21 09:13:57 EDT

fixed