Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 286306

Summary: [Toolbar] ToolItem indices are messed up by DROP_DOWN
Product: [RT] RAP Reporter: Benjamin Muskalla <b.muskalla>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.3   
Target Milestone: 1.3 M1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch+testcase none

Description Benjamin Muskalla CLA 2009-08-11 14:06:52 EDT 
With the fix for bug 285581 there was a regression introduced. As we now rely on the index to add the items to the client-side toolbar, these indices can be messed up by the client-side DROP_DOWN implementation. Currently the client side Drop down item consists of two items which infer with the index on the serverside where the dropdown is only one item.
We should see that this will be fixed for M1.
Comment 1 Benjamin Muskalla CLA 2009-08-12 07:50:45 EDT 
Created attachment 144206 [details]
patch+testcase

I don't see another chance than recomputing the index based on the assumption that the client-side widget consists of two widgets.
Ralf, any opinion on this one? I really don't like this workaround but I see no way we can get this fixed in any other way.
Workaround+testcase will be obsolete once we have a proper DROP_DOWN ToolItem implementation that consists of only one widget.
Comment 2 Ralf Sternberg CLA 2009-08-13 10:38:57 EDT 
I think the patch is fine until we have a better toolitem implementation.
Applied to CVS HEAD.