Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 286236

Summary:

[LnF] Modulegroups vertical Scroll

Product:

[RT] Riena

Reporter:

ekkehard gentz <ekke>

Component:

Look And Feel

Assignee:

Project Inbox <riena.ui-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

christian.campo, florian.pirchner, yang.meyer

Version:

1.1.0

Target Milestone:

---

Hardware:

Macintosh

OS:

Mac OS X

Whiteboard:

Attachments:

Description	Flags
two only party visible Buttons at the Bottom	none

Description ekkehard gentz

2009-08-11 09:29:15 EDT

If there are more ModuleGroups then could be displayed in current Screensize,
then I found out:

* there's no vertical Scrollbar, but I can use Mouse-Scroll or (OSX) Touchpad to scroll
thats OK

* there also seem to be two Buttons at the Bottom
If you look at attached Screenshot, you'll see them at the bottom,
but only partly - no Text, no Icons

I tried them and found out that I can use these Buttons to navigate vertical up / down

They should be visible - and it also would be good to have an Icon there.

Comment 1 ekkehard gentz

2009-08-11 09:30:17 EDT

Created attachment 144037 [details]
two only party visible Buttons at the Bottom

Comment 2 Christian Campo

2009-08-11 10:02:21 EDT

we intentionally dont have a scrollbar but rather two buttons on the bottom. Its possibly a mac problem that the vertical size is not high enough.....on windows they have up and down arrows.

Comment 3 ekkehard gentz

2009-08-11 10:17:38 EDT

Christian,
thx for info.

its no problem to work without scrollbar there

the two buttons become visible if not all can be displayed,
but as you can see from screenshot (on OSX) they are only partly visible without an arrow,
so it seems to be an OSX problem

ekke

Comment 4 Christian Campo

2009-08-11 10:24:26 EDT

Maybe that is a problem that you can check out yourself, since you are a committer and no one except me has a Mac among the committers other than you :-).

I can support you once you have a fix to test that it also works on my Mac and on my Windows machine before you commit it.

If you have some time left...

Comment 5 ekkehard gentz

2009-08-11 10:33:18 EDT

perhaps you have a hint where to start to look into lnf code

...if you have some time left ;-)

Comment 6 Elias Volanakis

2009-08-11 15:19:30 EDT

Here are some starting points (use Open Type aka Ctrl+T to find them):

ScrollingSupport    (this is consumen by NavigationViewPart)
ScrollControlComposite#initControlButtons      (SCC is an inner class of ScrollingSupport)
ScrollControlComposite#layoutDownButton
ScrollControlComposite#layoutUpButton

One obvious problem is that the layoutXXX methods use hard-coded pixel values, which are different between win / mac.

Hope this helps,
Elias.

Comment 7 ekkehard gentz

2009-08-11 16:12:22 EDT

thx elias,

this helps much.

I'll take a look at this.

in redView we always calculate absolute values depending from OS

perhaps I found a way to re-calculate values in Riena, too,
but this is sometimes not easy ;-)



ekke

Comment 8 Elias Volanakis

2009-08-11 20:46:46 EDT

A related idea: personally I also think that FormLayout is maybe not a very good way to place these two buttons, since it requires pixel values. Maybe one can use GridLayout or FillLayout instead (which deal better with different sized widgets).

Comment 9 Thorsten Schenkel

2011-08-02 10:44:09 EDT

Now (Jan. 2011) it possible to set the height of the navigation scroll-buttons in the Riena LnF (NAVIGATION_SCROLL_BUTTON_HEIGHT). Use a greater value for the button height. So the images on the buttons should be visible.